You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2020/12/07 22:08:43 UTC

[Bug 64962] New: Save sub results doesn't show all sub results in VRT listener

https://bz.apache.org/bugzilla/show_bug.cgi?id=64962

            Bug ID: 64962
           Summary: Save sub results doesn't show all sub results in VRT
                    listener
           Product: JMeter
           Version: Nightly (Please specify date)
          Hardware: PC
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: nalexic@gmail.com
  Target Milestone: JMETER 5.4.1

Created attachment 37592
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37592&action=edit
jmx file

Hello,

If "Save sub results" is checked in Configuration menu in VRT listener, it
seems that only one child sub result is visible when csv file is loaded. If the
same is done using jtl file, all sub results are visible. Is this intended
behavior? Please run jmx file and load csv/jtl files in VRT listener and
compare results.

Jmeter 5.4.1 c7f309f
Microsoft Windows 10 Pro 64-bit
java version "1.8.0_251"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64962] Save sub results doesn't show all sub results in VRT listener

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64962

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om

--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
(In reply to Felix Schumacher from comment #2)
> @all should we include this in the next release (4.5.1), or should we play
> safe and wait for the next one after this?
> 
> @eR@SeR are you able to compile the code with the patch yourself?

Hello,
I am in favor of playing safe.
Regards

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64962] Save sub results doesn't show all sub results in VRT listener

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64962

eR@SeR <na...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|CLOSED                      |REOPENED

--- Comment #10 from eR@SeR <na...@gmail.com> ---
Hi Felix,

Wrong https://bz.apache.org/bugzilla/attachment.cgi?id=37597&action=diff patch
is applied. Same issue described in
https://bz.apache.org/bugzilla/show_bug.cgi?id=64962#c5 happens. The one that
worked fine is
https://bz.apache.org/bugzilla/attachment.cgi?id=37617&action=diff

(In reply to Felix Schumacher from comment #9)
> The fix has not been in JMeter 5.4.1 as this is on the border between a bug
> fix and an enhancement. But it is included in trunk now and will be in the
> next release.
I meant to add in nightly that was published on Jan 26th, not to add in version
5.4.1 that was already published.

Jmeter 5.5 acdb648
Microsoft Windows 10 Pro 64-bit
java version "15.0.1" 2020-10-20

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64962] Save sub results doesn't show all sub results in VRT listener

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64962

Felix Schumacher <fe...@internetallee.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37597|0                           |1
        is obsolete|                            |

--- Comment #6 from Felix Schumacher <fe...@internetallee.de> ---
Created attachment 37617
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37617&action=edit
Recurse into sub results when saving CSV from VRT

Thanks for the feedback. The order should be fixed now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64962] Save sub results doesn't show all sub results in VRT listener

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64962

eR@SeR <na...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from eR@SeR <na...@gmail.com> ---
Hi Felix,

Well done! The order of sub results has been fixed on the provided and real
test plan. Thank you.

Jmeter 5.4.1 58ad5bc
Microsoft Windows 10 Pro 64-bit
java version "1.8.0_251"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64962] Save sub results doesn't show all sub results in VRT listener

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64962

eR@SeR <na...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from eR@SeR <na...@gmail.com> ---
Hi Felix,

The order is correct now. Thank you.

Jmeter 5.5 25ab888
Microsoft Windows 10 Pro 64-bit
java version "15.0.1" 2020-10-20

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64962] Save sub results doesn't show all sub results in VRT listener

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64962

--- Comment #5 from eR@SeR <na...@gmail.com> ---
Created attachment 37609
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37609&action=edit
transaction controllers are shown at the bottom, sampler-subresult are switched

Hello,

@Felix
Thank you for sending me the compiled JMeter. Subresults are visible on the
provided and real test plan.

However, when csv file is loaded, the order of sampler and subresult is
switched in both test plans if samplers are inside Transaction Controller and
'Generate parent sample' is checked. Please run jmx from attachment 37592.

If one or more Transaction controllers are added as a parent of Transaction
controller and 'Generate parent sample' is checked in all, Transaction
Controllers are shown at the bottom, instead to follow the order of appearance
when actual test is run. When jtl file is loaded, the order of elements and
subresults are fine. Check image for more info.

Jmeter 5.4.1 3e5421f
Microsoft Windows 10 Pro 64-bit
java version "1.8.0_251"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64962] Save sub results doesn't show all sub results in VRT listener

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64962

Felix Schumacher <fe...@internetallee.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All
             Status|NEW                         |NEEDINFO
           Keywords|                            |PatchAvailable

--- Comment #2 from Felix Schumacher <fe...@internetallee.de> ---
@all should we include this in the next release (4.5.1), or should we play safe
and wait for the next one after this?

@eR@SeR are you able to compile the code with the patch yourself?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64962] Save sub results doesn't show all sub results in VRT listener

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64962

--- Comment #3 from eR@SeR <na...@gmail.com> ---
No, I'm not able to compile the code, unfortunately. Can you do it instead and
send me the link to download binary?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64962] Save sub results doesn't show all sub results in VRT listener

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64962

--- Comment #8 from eR@SeR <na...@gmail.com> ---
Hi Felix,

I'm not sure if this fix is not included in latest nightly accidentally. Just
to update in case if it is.

Jmeter 5.5 ff9866a
Microsoft Windows 10 Pro 64-bit
java version "15.0.1" 2020-10-20

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64962] Save sub results doesn't show all sub results in VRT listener

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64962

Felix Schumacher <fe...@internetallee.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |FixedInTrunk
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Felix Schumacher <fe...@internetallee.de> ---
@Nikola, can you test the next build from trunk or nightly?

The fix has not been in JMeter 5.4.1 as this is on the border between a bug fix
and an enhancement. But it is included in trunk now and will be in the next
release.

commit f905a07259e5e6c092a619ea3be281f7e6d041e0
AuthorDate: Thu Dec 10 17:02:13 2020 +0100

    Save CSV sub-results recursively from Visual Result Tree

    Bugzilla Id: 64962
---
 .../java/org/apache/jmeter/save/CSVSaveService.java    | 18 ++++++++++++++----
 xdocs/changes.xml                                      |  1 +
 2 files changed, 15 insertions(+), 4 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64962] Save sub results doesn't show all sub results in VRT listener

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64962

--- Comment #1 from Felix Schumacher <fe...@internetallee.de> ---
Created attachment 37597
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37597&action=edit
Recurse into sub results when saving CSV from VRT

The attached patch will probably fix your problem. At the moment the CSV
implementation saves only one level deep of subresults.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64962] Save sub results doesn't show all sub results in VRT listener

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64962

Felix Schumacher <fe...@internetallee.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEEDINFO

--- Comment #11 from Felix Schumacher <fe...@internetallee.de> ---
@nikola could you please test again, the order should be correct now.

commit eb8c962ef132964041ab10d12ba2bd168c68dfdb
Author: Felix Schumacher <fe...@internetallee.de>
AuthorDate: Mon Feb 15 17:31:33 2021 +0100

    Save sub-results in correct order

    Bugzilla Id: 64962
---
 src/core/src/main/java/org/apache/jmeter/save/CSVSaveService.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.