You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/07/25 19:20:02 UTC

[GitHub] [couchdb-ioq] chewbranca commented on a diff in pull request #21: Add IOQ2 pid for search traffic

chewbranca commented on code in PR #21:
URL: https://github.com/apache/couchdb-ioq/pull/21#discussion_r929219184


##########
include/ioq.hrl:
##########
@@ -19,6 +19,8 @@
 -define(DISPATCH_SINGLE_SERVER, "single_server").
 -define(DISPATCH_SERVER_PER_SCHEDULER, "server_per_scheduler").
 
+-define(IOQ2_SEARCH_SERVER, ioq_server_search).

Review Comment:
   Well, it's deliberate that the server itself is `ioq_server_search` so that it starts with `ioq_server_` to utilize this logic flagging it as an IOQ2 pid: https://github.com/apache/couchdb-ioq/blob/d400e34e3637289081bab125b9c39e3c7b8a9d10/src/ioq_sup.erl#L87-L88
   
   I thought the define name was more natural, but we could reverse the name so they're identical.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org