[GitHub] [hadoop] xiaoyuyao commented on a change in pull request #1510: HDDS-2170. Add Object IDs and Update ID to Volume Object

[GitBox <gi...@apache.org>]

xiaoyuyao commented on a change in pull request #1510: HDDS-2170. Add Object IDs and Update ID to Volume Object
URL: https://github.com/apache/hadoop/pull/1510#discussion_r327411316
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeCreateRequest.java
 ##########
 @@ -116,6 +116,11 @@ public OMClientResponse validateAndUpdateCache(OzoneManager ozoneManager,
     Collection<String> ozAdmins = ozoneManager.getOzoneAdmins();
     try {
       omVolumeArgs = OmVolumeArgs.getFromProtobuf(volumeInfo);
+      // when you create a volume, we set both Object ID and update ID to the
+      // same ratis transaction ID. The Object ID will never change, but update
+      // ID will be set to transactionID each time we update the object.
 
 Review comment:
   Do we need to add handling for updateID change in some volume metadata operations such as set/add/remove ACL, addMetadata, etc 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org