You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jesse Yates (JIRA)" <ji...@apache.org> on 2012/06/19 00:12:42 UTC

[jira] [Commented] (HBASE-6234) Move simple KeyValue tests to hbase-common module

    [ https://issues.apache.org/jira/browse/HBASE-6234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396307#comment-13396307 ] 

Jesse Yates commented on HBASE-6234:
------------------------------------

Looks reasonable to me. If it tests fine, I'm +1. Also, I think this is a good paradigm to follow for moving things up.
                
> Move simple KeyValue tests to hbase-common module
> -------------------------------------------------
>
>                 Key: HBASE-6234
>                 URL: https://issues.apache.org/jira/browse/HBASE-6234
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Matt Corgan
>            Assignee: Matt Corgan
>         Attachments: HBASE-6234-v1.patch
>
>
> TestKeyValue, LoadTestKVGenerator, and TestLoadTestKVGenerator should move up to hbase-common.  This brings MD5Hash up as a dependency as well.
> To play well with Maven as discussed in HBASE-6162, I moved LoadTestKVGenerator from the src/test folder to src/main folder so that tests in other modules can see it.  A couple other files' import statements were affected by this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira