[GitHub] michellethomas commented on a change in pull request #6298: Reduce data loaded before loading tests

[GitBox <gi...@apache.org>]

michellethomas commented on a change in pull request #6298: Reduce data loaded before loading tests
URL: https://github.com/apache/incubator-superset/pull/6298#discussion_r234392924
 
 

 ##########
 File path: superset/cli.py
 ##########
 @@ -154,42 +154,43 @@ def load_examples_run(load_test_data):
     print('Loading [Birth names]')
     data.load_birth_names()
 
-    print('Loading [Random time series data]')
-    data.load_random_time_series_data()
+    if not load_test_data:
+        print('Loading [Random time series data]')
+        data.load_random_time_series_data()
 
-    print('Loading [Random long/lat data]')
-    data.load_long_lat_data()
+        print('Loading [Random long/lat data]')
+        data.load_long_lat_data()
 
-    print('Loading [Country Map data]')
-    data.load_country_map_data()
+        print('Loading [Country Map data]')
+        data.load_country_map_data()
 
-    print('Loading [Multiformat time series]')
-    data.load_multiformat_time_series()
+        print('Loading [Multiformat time series]')
+        data.load_multiformat_time_series()
 
-    print('Loading [Paris GeoJson]')
-    data.load_paris_iris_geojson()
+        print('Loading [Paris GeoJson]')
+        data.load_paris_iris_geojson()
 
-    print('Loading [San Francisco population polygons]')
-    data.load_sf_population_polygons()
+        print('Loading [San Francisco population polygons]')
+        data.load_sf_population_polygons()
 
-    print('Loading [Flights data]')
-    data.load_flights()
+        print('Loading [Flights data]')
+        data.load_flights()
 
-    print('Loading [BART lines]')
-    data.load_bart_lines()
+        print('Loading [BART lines]')
+        data.load_bart_lines()
 
-    print('Loading [Multi Line]')
-    data.load_multi_line()
+        print('Loading [Multi Line]')
+        data.load_multi_line()
 
-    print('Loading [Misc Charts] dashboard')
-    data.load_misc_dashboard()
+        print('Loading [Misc Charts] dashboard')
+        data.load_misc_dashboard()
 
-    if load_test_data:
-        print('Loading [Unicode test data]')
-        data.load_unicode_test_data()
+        if load_test_data:
 
 Review comment:
   This is nested under `if not load_test_data:`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org