You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2015/11/16 14:53:16 UTC
Review Request 40346: [2/4] Quota Authorization: Implemented
authorization of quota requests in the authorizer.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40346/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till Toenshoff.
Bugs: MESOS-3862
https://issues.apache.org/jira/browse/MESOS-3862
Repository: mesos
Description
-------
Quota: Implemented authorization of quota requests in the authorizer.
Diffs
-----
include/mesos/authorizer/authorizer.hpp d667a52f90f970a313580446a5a006cec4b5e25b
src/authorizer/local/authorizer.hpp 32de102fd588f029882ef2222121ca83a7410c65
src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773
src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed
Diff: https://reviews.apache.org/r/40346/diff/
Testing
-------
Thanks,
Jan Schlicht
Re: Review Request 40346: [2/4] Quota Authorization: Implemented
authorization of quota requests in the authorizer.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40346/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 4:48 p.m.)
Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till Toenshoff.
Changes
-------
Fix issues.
Bugs: MESOS-3862
https://issues.apache.org/jira/browse/MESOS-3862
Repository: mesos
Description
-------
Quota: Implemented authorization of quota requests in the authorizer.
Diffs (updated)
-----
include/mesos/authorizer/authorizer.hpp d667a52f90f970a313580446a5a006cec4b5e25b
src/authorizer/local/authorizer.hpp 32de102fd588f029882ef2222121ca83a7410c65
src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773
src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed
Diff: https://reviews.apache.org/r/40346/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 40346: [2/4] Quota Authorization: Implemented
authorization of quota requests in the authorizer.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On Nov. 16, 2015, 3:23 p.m., Joerg Schad wrote:
> > src/tests/mesos.hpp, line 1245
> > <https://reviews.apache.org/r/40346/diff/1/?file=1126219#file1126219line1245>
> >
> > This looks somehow weird... Who is satisfying the expect_call?
>
> Guangya Liu wrote:
> I also have the same question, seems no one will trigger this.
This call does not need to be called, as described in https://code.google.com/p/googlemock/wiki/CheatSheet#Setting_Expectations
`EXPECT_CALL` will assume a cardinality >=0 if used with `WillRepeatedly()`.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40346/#review106660
-----------------------------------------------------------
On Nov. 16, 2015, 4:48 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40346/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 4:48 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till Toenshoff.
>
>
> Bugs: MESOS-3862
> https://issues.apache.org/jira/browse/MESOS-3862
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Quota: Implemented authorization of quota requests in the authorizer.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp d667a52f90f970a313580446a5a006cec4b5e25b
> src/authorizer/local/authorizer.hpp 32de102fd588f029882ef2222121ca83a7410c65
> src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773
> src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed
>
> Diff: https://reviews.apache.org/r/40346/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 40346: [2/4] Quota Authorization: Implemented
authorization of quota requests in the authorizer.
Posted by Guangya Liu <gy...@gmail.com>.
> On 十一月 16, 2015, 2:23 p.m., Joerg Schad wrote:
> > src/tests/mesos.hpp, line 1245
> > <https://reviews.apache.org/r/40346/diff/1/?file=1126219#file1126219line1245>
> >
> > This looks somehow weird... Who is satisfying the expect_call?
I also have the same question, seems no one will trigger this.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40346/#review106660
-----------------------------------------------------------
On 十一月 16, 2015, 3:48 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40346/
> -----------------------------------------------------------
>
> (Updated 十一月 16, 2015, 3:48 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till Toenshoff.
>
>
> Bugs: MESOS-3862
> https://issues.apache.org/jira/browse/MESOS-3862
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Quota: Implemented authorization of quota requests in the authorizer.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp d667a52f90f970a313580446a5a006cec4b5e25b
> src/authorizer/local/authorizer.hpp 32de102fd588f029882ef2222121ca83a7410c65
> src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773
> src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed
>
> Diff: https://reviews.apache.org/r/40346/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 40346: [2/4] Quota Authorization: Implemented
authorization of quota requests in the authorizer.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40346/#review106660
-----------------------------------------------------------
include/mesos/authorizer/authorizer.hpp (line 136)
<https://reviews.apache.org/r/40346/#comment165394>
s/request/set
include/mesos/authorizer/authorizer.hpp (line 140)
<https://reviews.apache.org/r/40346/#comment165395>
/s/Then/This
src/tests/mesos.hpp (line 1245)
<https://reviews.apache.org/r/40346/#comment165396>
This looks somehow weird... Who is satisfying the expect_call?
- Joerg Schad
On Nov. 16, 2015, 1:53 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40346/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 1:53 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till Toenshoff.
>
>
> Bugs: MESOS-3862
> https://issues.apache.org/jira/browse/MESOS-3862
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Quota: Implemented authorization of quota requests in the authorizer.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.hpp d667a52f90f970a313580446a5a006cec4b5e25b
> src/authorizer/local/authorizer.hpp 32de102fd588f029882ef2222121ca83a7410c65
> src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773
> src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed
>
> Diff: https://reviews.apache.org/r/40346/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 40346: [2/4] Quota Authorization: Implemented
authorization of quota requests in the authorizer.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40346/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 2:53 p.m.)
Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till Toenshoff.
Bugs: MESOS-3862
https://issues.apache.org/jira/browse/MESOS-3862
Repository: mesos
Description
-------
Quota: Implemented authorization of quota requests in the authorizer.
Diffs
-----
include/mesos/authorizer/authorizer.hpp d667a52f90f970a313580446a5a006cec4b5e25b
src/authorizer/local/authorizer.hpp 32de102fd588f029882ef2222121ca83a7410c65
src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773
src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed
Diff: https://reviews.apache.org/r/40346/diff/
Testing (updated)
-------
make check
Thanks,
Jan Schlicht