[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #3626: libc: Move pthread stuff to userspace

[GitBox <gi...@apache.org>]

no1wudi edited a comment on pull request #3626:
URL: https://github.com/apache/incubator-nuttx/pull/3626#issuecomment-829779823


   > build is failing because of:
   > 
   > ```
   > stubs/STUB_nx_pthread_exit.c: In function 'STUB_nx_pthread_exit':
   > Error: stubs/STUB_nx_pthread_exit.c:12:1: error: control reaches end of non-void function [-Werror=return-type]
   >    12 | }
   >       | ^
   > ```
   > 
   > That should be handled as it is for other no return functions:
   > 
   > ```
   > syscall.csv:"_exit","unistd.h","","noreturn","int"
   > syscall.csv:"exit","stdlib.h","","noreturn","int"
   > syscall.csv:"pthread_exit","pthread.h","!defined(CONFIG_DISABLE_PTHREAD)","noreturn","pthread_addr_t"
   > ```
   > 
   > But you have:
   > 
   > ```
   > "nx_pthread_exit","nuttx/pthread.h","!defined(CONFIG_DISABLE_PTHREAD)","noreturn","pthread_addr_t"
   > ```
   > 
   > So I don't understand what the issue is.
   
   Fixed, I forget to add `noreturn_function` attribute to the declaration of nx_pthread_exit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org