[GitHub] zeppelin pull request #2852: [ZEPPELIN-3264] Notebook Snapshot feature.

[SleepyThread <gi...@git.apache.org>]

GitHub user SleepyThread opened a pull request:

    https://github.com/apache/zeppelin/pull/2852

    [ZEPPELIN-3264] Notebook Snapshot feature.

    ### What is this PR for?
    Currently, a user can share the notebook with other users. There is a usage pattern where data analyst creates notebook report and then share with other stakeholders. Meanwhile, they would like to update/change the report and re-publish the results.  
    
    
    We need a shareable url like,
     /notebook/{**Notebook ID**}/view/{**Snapshot Name**}
    
    which can be shared to other users and can be updated with a logical sharable report. 
    
    
    ### What type of PR is it?
    [ Feature | Documentation]
    
    ### Todos
    * [ ] - CSS and assets changes. 
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3264
    
    ### How should this be tested?
    * Create git based Notebook. 
    * Create 1st commit. 
    * Add a snapshot ID. 
    * View the snapshot. 
    
    ### Screenshots (if appropriate)
    
    
    
    ![create_snapshot](https://user-images.githubusercontent.com/858038/36646998-ffca9ce6-1a76-11e8-9101-23a070a0b532.gif)
    
    
    
    ### Questions:
    * Does the licenses files need update?
     - No
    * Is there breaking changes for older versions?
     - No.
    * Does this needs documentation?
     - Yes. Already updated. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SleepyThread/zeppelin ZEPPELIN-3264_notebook_snapshots

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2852.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2852
    
----
commit ae92c6e23064278ce5ac67669718c3aea927b1a2
Author: Akash <ak...@...>
Date:   2018-02-24T22:10:48Z

    [ZEPPELIN-3264] Notebook Snapshot feature.

----


---

[GitHub] zeppelin issue #2852: [ZEPPELIN-3264] Notebook Snapshot feature.

[zjffdu <gi...@git.apache.org>]

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2852
  
    >  Git tag regularly is not something feels right [ Usually in practice Git Tag are to be done only once ].
    
    That is my understanding of the snapshot scenario. Snapshot is only readable, but not writable. When user view snapshot of one note, zeppelin just fetch the note at that tag. Let me know if my understanding of your snapshot scenario is not correct.  


---

[GitHub] zeppelin issue #2852: [ZEPPELIN-3264] Notebook Snapshot feature.

[SleepyThread <gi...@git.apache.org>]

Github user SleepyThread commented on the issue:

    https://github.com/apache/zeppelin/pull/2852
  
    @Leemoonsoo @zjffdu friendly reminder regarding this pull request. 


---

[GitHub] zeppelin issue #2852: [ZEPPELIN-3264] Notebook Snapshot feature.

[SleepyThread <gi...@git.apache.org>]

Github user SleepyThread commented on the issue:

    https://github.com/apache/zeppelin/pull/2852
  
    @zjffdu Implementation using Git Tag is also another approach but updating/delete Git tag regularly is not something feels right [ Usually in practice Git Tag are to be done only once ]. Hence, I have used file-based approach for storing a mapping of Snapshot ID => Revision ID.
    
    Let me know if you feel strongly about the other approach, and I work on the Git Tag based implementation. 


---

[GitHub] zeppelin issue #2852: [ZEPPELIN-3264] Notebook Snapshot feature.

[zjffdu <gi...@git.apache.org>]

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2852
  
    > Meanwhile, they would like to update/change the report and re-publish the results.
    
    If they update/change the report, should they create another snapshot ?
    
    Here's my understanding of this scenario. The snapshot is only readable, and user can only see this report. (maybe they can update it, but only via dynamic forms, so the paragraph text is readable, only the result can be changed).
    
    If the above scenario is reasonable,then I think we can just create git tag for snapshot instead of saving the snapshot into file. And only retrieve that tag from git repo when user open that snapshot. 


---

[GitHub] zeppelin issue #2852: [ZEPPELIN-3264] Notebook Snapshot feature.

[mebelousov <gi...@git.apache.org>]

Github user mebelousov commented on the issue:

    https://github.com/apache/zeppelin/pull/2852
  
    Will the git storage allow to delete older snapshots?
    I see the scenario: every day create new snapshot and delete the oldest snapshot.


---

[GitHub] zeppelin issue #2852: [ZEPPELIN-3264] Notebook Snapshot feature.

[jongyoul <gi...@git.apache.org>]

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2852
  
    Can someone tell me the status of this issue?


---