You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2016/10/05 21:28:56 UTC
Review Request 52575: GEODE-1962: increment notQueuedConflated stat is
peeked object is unresolvable from off heap
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52575/
-----------------------------------------------------------
Review request for geode, nabarun nag and Dan Smith.
Repository: geode
Description
-------
There is a scenario where the stats do not reflect an event being conflated. After peeking the original object from the bucketRegionQueue, when we try to resolve from off heap, if the resolved value is null, we just continue. Instead we should behave similar to the bucketRegionQueue peek method, where it increments the stat if the object itself is null.
Minor refactoring and changing of method visibility for testing purposes
Removed some unused code
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 1a9b126
geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java f1d4408
Diff: https://reviews.apache.org/r/52575/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 52575: GEODE-1962: increment notQueuedConflated
stat is peeked object is unresolvable from off heap
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52575/#review152160
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Oct. 5, 2016, 9:28 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52575/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2016, 9:28 p.m.)
>
>
> Review request for geode, nabarun nag and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> There is a scenario where the stats do not reflect an event being conflated. After peeking the original object from the bucketRegionQueue, when we try to resolve from off heap, if the resolved value is null, we just continue. Instead we should behave similar to the bucketRegionQueue peek method, where it increments the stat if the object itself is null.
>
> Minor refactoring and changing of method visibility for testing purposes
> Removed some unused code
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 1a9b126
> geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueueJUnitTest.java f1d4408
>
> Diff: https://reviews.apache.org/r/52575/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>