You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "raboof (via GitHub)" <gi...@apache.org> on 2025/02/07 16:41:39 UTC
[PR] De-emphasize the 1.x version line on the website [commons-configuration]
raboof opened a new pull request, #539:
URL: https://github.com/apache/commons-configuration/pull/539
Clarify we do not expect it to work with untrusted input.
Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated!
Before you push a pull request, review this list:
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
- [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] De-emphasize the 1.x version line on the website [commons-configuration]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #539:
URL: https://github.com/apache/commons-configuration/pull/539#discussion_r1946842223
##########
src/site/xdoc/download_configuration.xml:
##########
@@ -145,36 +145,6 @@ limitations under the License.
</table>
</subsection>
</section>
- <section name="Apache Commons Configuration 1.10 (old 1.x version)">
- <subsection name="Binaries">
- <table>
- <tr>
- <td><a href="[preferred]/commons/configuration/binaries/commons-configuration-1.10-bin.tar.gz">commons-configuration-1.10-bin.tar.gz</a></td>
Review Comment:
All this stuff is generated based on POM properties so it will show up again unless you edit pom.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] De-emphasize the 1.x version line on the website [commons-configuration]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #539:
URL: https://github.com/apache/commons-configuration/pull/539#discussion_r1946849478
##########
src/site/xdoc/download_configuration.xml:
##########
@@ -145,36 +145,6 @@ limitations under the License.
</table>
</subsection>
</section>
- <section name="Apache Commons Configuration 1.10 (old 1.x version)">
- <subsection name="Binaries">
- <table>
- <tr>
- <td><a href="[preferred]/commons/configuration/binaries/commons-configuration-1.10-bin.tar.gz">commons-configuration-1.10-bin.tar.gz</a></td>
Review Comment:
ah, removed the `commons.release.2`, LMK if I missed anything else (or if there's an easy way for me to check for myself)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] De-emphasize the 1.x version line on the website [commons-configuration]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #539:
URL: https://github.com/apache/commons-configuration/pull/539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org