You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by xu...@apache.org on 2025/10/28 17:49:08 UTC
(iceberg-rust) 01/01: refactor: Migrate from tera to minijinja
This is an automated email from the ASF dual-hosted git repository.
xuanwo pushed a commit to branch miratge-to-minijinja
in repository https://gitbox.apache.org/repos/asf/iceberg-rust.git
commit 276a6bc0cc16777dcba0ce00270749dcae2498c0
Author: Xuanwo <gi...@xuanwo.io>
AuthorDate: Wed Oct 29 01:48:34 2025 +0800
refactor: Migrate from tera to minijinja
Signed-off-by: Xuanwo <gi...@xuanwo.io>
---
Cargo.lock | 306 +++-------------------------------
Cargo.toml | 2 +-
crates/iceberg/Cargo.toml | 2 +-
crates/iceberg/src/io/object_cache.rs | 24 ++-
crates/iceberg/src/scan/mod.rs | 52 +++---
5 files changed, 70 insertions(+), 316 deletions(-)
diff --git a/Cargo.lock b/Cargo.lock
index f4085e59e..c5f3bc225 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -264,7 +264,7 @@ dependencies = [
"arrow-data",
"arrow-schema",
"chrono",
- "chrono-tz 0.10.4",
+ "chrono-tz",
"half",
"hashbrown 0.15.5",
"num",
@@ -1263,16 +1263,6 @@ dependencies = [
"alloc-stdlib",
]
-[[package]]
-name = "bstr"
-version = "1.12.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "234113d19d0d7d613b40e86fb654acf958910802bcceab913a4f9e7cda03b1a4"
-dependencies = [
- "memchr",
- "serde",
-]
-
[[package]]
name = "bumpalo"
version = "3.19.0"
@@ -1426,17 +1416,6 @@ dependencies = [
"windows-link",
]
-[[package]]
-name = "chrono-tz"
-version = "0.9.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "93698b29de5e97ad0ae26447b344c482a7284c737d9ddc5f9e52b74a336671bb"
-dependencies = [
- "chrono",
- "chrono-tz-build",
- "phf 0.11.3",
-]
-
[[package]]
name = "chrono-tz"
version = "0.10.4"
@@ -1444,18 +1423,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "a6139a8597ed92cf816dfb33f5dd6cf0bb93a6adc938f11039f371bc5bcd26c3"
dependencies = [
"chrono",
- "phf 0.12.1",
-]
-
-[[package]]
-name = "chrono-tz-build"
-version = "0.3.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "0c088aee841df9c3041febbb73934cfc39708749bf96dc827e3359cd39ef11b1"
-dependencies = [
- "parse-zoneinfo",
- "phf 0.11.3",
- "phf_codegen",
+ "phf",
]
[[package]]
@@ -1702,16 +1670,6 @@ dependencies = [
"crossbeam-utils",
]
-[[package]]
-name = "crossbeam-deque"
-version = "0.8.6"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "9dd111b7b7f7d55b72c0a6ae361660ee5853c9af73f70c3c2ef6858b950e2e51"
-dependencies = [
- "crossbeam-epoch",
- "crossbeam-utils",
-]
-
[[package]]
name = "crossbeam-epoch"
version = "0.9.18"
@@ -2665,12 +2623,6 @@ dependencies = [
"syn 2.0.107",
]
-[[package]]
-name = "deunicode"
-version = "1.6.2"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "abd57806937c9cc163efc8ea3910e00a62e2aeb0b8119f1793a978088f8f6b04"
-
[[package]]
name = "diff"
version = "0.1.13"
@@ -2707,7 +2659,7 @@ dependencies = [
"libc",
"option-ext",
"redox_users",
- "windows-sys 0.59.0",
+ "windows-sys 0.61.2",
]
[[package]]
@@ -2849,7 +2801,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "39cab71617ae0d63f51a36d69f866391735b51691dbda63cf6f96d042b63efeb"
dependencies = [
"libc",
- "windows-sys 0.59.0",
+ "windows-sys 0.61.2",
]
[[package]]
@@ -3189,30 +3141,6 @@ version = "0.3.3"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "0cc23270f6e1808e30a928bdc84dea0b9b4136a8bc82338574f23baf47bbd280"
-[[package]]
-name = "globset"
-version = "0.4.17"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "eab69130804d941f8075cfd713bf8848a2c3b3f201a9457a11e6f87e1ab62305"
-dependencies = [
- "aho-corasick",
- "bstr",
- "log",
- "regex-automata",
- "regex-syntax",
-]
-
-[[package]]
-name = "globwalk"
-version = "0.9.1"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "0bf760ebf69878d9fd8f110c89703d90ce35095324d1f1edcb595c63945ee757"
-dependencies = [
- "bitflags",
- "ignore",
- "walkdir",
-]
-
[[package]]
name = "gloo-timers"
version = "0.3.0"
@@ -3445,15 +3373,6 @@ version = "1.0.3"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "df3b46402a9d5adb4c86a0cf463f42e19994e3ee891101b1841f30a545cb49a9"
-[[package]]
-name = "humansize"
-version = "2.1.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "6cb51c9a029ddc91b07a787f1d86b53ccfa49b0e86688c946ebe8d3555685dd7"
-dependencies = [
- "libm",
-]
-
[[package]]
name = "humantime"
version = "2.3.0"
@@ -3618,6 +3537,7 @@ dependencies = [
"futures",
"iceberg_test_utils",
"itertools 0.13.0",
+ "minijinja",
"mockall",
"moka",
"murmur3",
@@ -3642,7 +3562,6 @@ dependencies = [
"smol",
"strum 0.27.2",
"tempfile",
- "tera",
"thrift",
"tokio",
"typed-builder 0.20.1",
@@ -3976,22 +3895,6 @@ dependencies = [
"icu_properties",
]
-[[package]]
-name = "ignore"
-version = "0.4.24"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "81776e6f9464432afcc28d03e52eb101c93b6f0566f52aef2427663e700f0403"
-dependencies = [
- "crossbeam-deque",
- "globset",
- "log",
- "memchr",
- "regex-automata",
- "same-file",
- "walkdir",
- "winapi-util",
-]
-
[[package]]
name = "indexmap"
version = "1.9.3"
@@ -4447,6 +4350,15 @@ dependencies = [
"libmimalloc-sys",
]
+[[package]]
+name = "minijinja"
+version = "2.12.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "a9f264d75233323f4b7d2f03aefe8a990690cdebfbfe26ea86bcbaec5e9ac990"
+dependencies = [
+ "serde",
+]
+
[[package]]
name = "minimal-lexical"
version = "0.2.1"
@@ -4656,7 +4568,7 @@ version = "0.50.3"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "7957b9740744892f114936ab4a57b3f487491bbeafaf8083688b16841a4240e5"
dependencies = [
- "windows-sys 0.59.0",
+ "windows-sys 0.61.2",
]
[[package]]
@@ -4992,15 +4904,6 @@ dependencies = [
"zstd",
]
-[[package]]
-name = "parse-zoneinfo"
-version = "0.3.1"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1f2a05b18d44e2957b88f96ba460715e295bc1d7510468a2f3d3b44535d26c24"
-dependencies = [
- "regex",
-]
-
[[package]]
name = "paste"
version = "1.0.15"
@@ -5079,49 +4982,6 @@ version = "2.3.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "9b4f627cb1b25917193a259e49bdad08f671f8d9708acfd5fe0a8c1455d87220"
-[[package]]
-name = "pest"
-version = "2.8.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "989e7521a040efde50c3ab6bbadafbe15ab6dc042686926be59ac35d74607df4"
-dependencies = [
- "memchr",
- "ucd-trie",
-]
-
-[[package]]
-name = "pest_derive"
-version = "2.8.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "187da9a3030dbafabbbfb20cb323b976dc7b7ce91fcd84f2f74d6e31d378e2de"
-dependencies = [
- "pest",
- "pest_generator",
-]
-
-[[package]]
-name = "pest_generator"
-version = "2.8.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "49b401d98f5757ebe97a26085998d6c0eecec4995cad6ab7fc30ffdf4b052843"
-dependencies = [
- "pest",
- "pest_meta",
- "proc-macro2",
- "quote",
- "syn 2.0.107",
-]
-
-[[package]]
-name = "pest_meta"
-version = "2.8.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "72f27a2cfee9f9039c4d86faa5af122a0ac3851441a34865b8a043b46be0065a"
-dependencies = [
- "pest",
- "sha2",
-]
-
[[package]]
name = "petgraph"
version = "0.7.1"
@@ -5144,51 +5004,13 @@ dependencies = [
"serde",
]
-[[package]]
-name = "phf"
-version = "0.11.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1fd6780a80ae0c52cc120a26a1a42c1ae51b247a253e4e06113d23d2c2edd078"
-dependencies = [
- "phf_shared 0.11.3",
-]
-
[[package]]
name = "phf"
version = "0.12.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "913273894cec178f401a31ec4b656318d95473527be05c0752cc41cdc32be8b7"
dependencies = [
- "phf_shared 0.12.1",
-]
-
-[[package]]
-name = "phf_codegen"
-version = "0.11.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "aef8048c789fa5e851558d709946d6d79a8ff88c0440c587967f8e94bfb1216a"
-dependencies = [
- "phf_generator",
- "phf_shared 0.11.3",
-]
-
-[[package]]
-name = "phf_generator"
-version = "0.11.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "3c80231409c20246a13fddb31776fb942c38553c51e871f8cbd687a4cfb5843d"
-dependencies = [
- "phf_shared 0.11.3",
- "rand 0.8.5",
-]
-
-[[package]]
-name = "phf_shared"
-version = "0.11.3"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "67eabc2ef2a60eb7faa00097bd1ffdb5bd28e62bf39990626a582201b7a754e5"
-dependencies = [
- "siphasher",
+ "phf_shared",
]
[[package]]
@@ -5640,7 +5462,7 @@ dependencies = [
"once_cell",
"socket2 0.6.1",
"tracing",
- "windows-sys 0.59.0",
+ "windows-sys 0.60.2",
]
[[package]]
@@ -6103,7 +5925,7 @@ dependencies = [
"errno",
"libc",
"linux-raw-sys",
- "windows-sys 0.59.0",
+ "windows-sys 0.61.2",
]
[[package]]
@@ -6651,16 +6473,6 @@ version = "0.4.11"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "7a2ae44ef20feb57a68b23d846850f861394c2e02dc425a50098ae8c90267589"
-[[package]]
-name = "slug"
-version = "0.1.6"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "882a80f72ee45de3cc9a5afeb2da0331d58df69e4e7d8eeb5d3c7784ae67e724"
-dependencies = [
- "deunicode",
- "wasm-bindgen",
-]
-
[[package]]
name = "smallvec"
version = "1.15.1"
@@ -7185,29 +6997,7 @@ dependencies = [
"getrandom 0.3.4",
"once_cell",
"rustix",
- "windows-sys 0.59.0",
-]
-
-[[package]]
-name = "tera"
-version = "1.20.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "ab9d851b45e865f178319da0abdbfe6acbc4328759ff18dafc3a41c16b4cd2ee"
-dependencies = [
- "chrono",
- "chrono-tz 0.9.0",
- "globwalk",
- "humansize",
- "lazy_static",
- "percent-encoding",
- "pest",
- "pest_derive",
- "rand 0.8.5",
- "regex",
- "serde",
- "serde_json",
- "slug",
- "unic-segment",
+ "windows-sys 0.61.2",
]
[[package]]
@@ -7703,62 +7493,6 @@ dependencies = [
"typify-impl",
]
-[[package]]
-name = "ucd-trie"
-version = "0.1.7"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "2896d95c02a80c6d6a5d6e953d479f5ddf2dfdb6a244441010e373ac0fb88971"
-
-[[package]]
-name = "unic-char-property"
-version = "0.9.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a8c57a407d9b6fa02b4795eb81c5b6652060a15a7903ea981f3d723e6c0be221"
-dependencies = [
- "unic-char-range",
-]
-
-[[package]]
-name = "unic-char-range"
-version = "0.9.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "0398022d5f700414f6b899e10b8348231abf9173fa93144cbc1a43b9793c1fbc"
-
-[[package]]
-name = "unic-common"
-version = "0.9.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "80d7ff825a6a654ee85a63e80f92f054f904f21e7d12da4e22f9834a4aaa35bc"
-
-[[package]]
-name = "unic-segment"
-version = "0.9.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "e4ed5d26be57f84f176157270c112ef57b86debac9cd21daaabbe56db0f88f23"
-dependencies = [
- "unic-ucd-segment",
-]
-
-[[package]]
-name = "unic-ucd-segment"
-version = "0.9.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "2079c122a62205b421f499da10f3ee0f7697f012f55b675e002483c73ea34700"
-dependencies = [
- "unic-char-property",
- "unic-char-range",
- "unic-ucd-version",
-]
-
-[[package]]
-name = "unic-ucd-version"
-version = "0.9.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "96bd2f2237fe450fcd0a1d2f5f4e91711124f7857ba2e964247776ebeeb7b0c4"
-dependencies = [
- "unic-common",
-]
-
[[package]]
name = "unicode-bidi"
version = "0.3.18"
@@ -8117,7 +7851,7 @@ version = "0.1.11"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "c2a7b1c03c876122aa43f3020e6c3c3ee5c05081c9a00739faf7503aeba10d22"
dependencies = [
- "windows-sys 0.48.0",
+ "windows-sys 0.61.2",
]
[[package]]
diff --git a/Cargo.toml b/Cargo.toml
index 49eeff038..65f0d1e47 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -91,6 +91,7 @@ linkedbytes = "0.1.8"
log = "0.4.28"
metainfo = "0.7.14"
mimalloc = "0.1.46"
+minijinja = "2.12.0"
mockall = "0.13.1"
mockito = "1"
motore-macros = "0.4.3"
@@ -120,7 +121,6 @@ sqlx = { version = "0.8.1", default-features = false }
stacker = "0.1.20"
strum = "0.27.2"
tempfile = "3.18"
-tera = "1"
thrift = "0.17.0"
tokio = { version = "1.46.1", default-features = false }
toml = "0.8"
diff --git a/crates/iceberg/Cargo.toml b/crates/iceberg/Cargo.toml
index b831607aa..c9b1bb317 100644
--- a/crates/iceberg/Cargo.toml
+++ b/crates/iceberg/Cargo.toml
@@ -102,7 +102,7 @@ pretty_assertions = { workspace = true }
rand = { workspace = true }
regex = { workspace = true }
tempfile = { workspace = true }
-tera = { workspace = true }
+minijinja = { workspace = true }
[package.metadata.cargo-machete]
# These dependencies are added to ensure minimal dependency version
diff --git a/crates/iceberg/src/io/object_cache.rs b/crates/iceberg/src/io/object_cache.rs
index a23ff36b3..b6946187f 100644
--- a/crates/iceberg/src/io/object_cache.rs
+++ b/crates/iceberg/src/io/object_cache.rs
@@ -186,7 +186,7 @@ mod tests {
use std::fs;
use tempfile::TempDir;
- use tera::{Context, Tera};
+ use minijinja::{value::Value, AutoEscape, Environment, context};
use uuid::Uuid;
use super::*;
@@ -198,6 +198,12 @@ mod tests {
};
use crate::table::Table;
+ fn render_template(template: &str, ctx: Value) -> String {
+ let mut env = Environment::new();
+ env.set_auto_escape_callback(|_| AutoEscape::None);
+ env.render_str(template, ctx).unwrap()
+ }
+
struct TableTestFixture {
table_location: String,
table: Table,
@@ -222,13 +228,15 @@ mod tests {
env!("CARGO_MANIFEST_DIR")
))
.unwrap();
- let mut context = Context::new();
- context.insert("table_location", &table_location);
- context.insert("manifest_list_1_location", &manifest_list1_location);
- context.insert("manifest_list_2_location", &manifest_list2_location);
- context.insert("table_metadata_1_location", &table_metadata1_location);
-
- let metadata_json = Tera::one_off(&template_json_str, &context, false).unwrap();
+ let metadata_json = render_template(
+ &template_json_str,
+ context! {
+ table_location => &table_location,
+ manifest_list_1_location => &manifest_list1_location,
+ manifest_list_2_location => &manifest_list2_location,
+ table_metadata_1_location => &table_metadata1_location,
+ },
+ );
serde_json::from_str::<TableMetadata>(&metadata_json).unwrap()
};
diff --git a/crates/iceberg/src/scan/mod.rs b/crates/iceberg/src/scan/mod.rs
index 3d14b3cce..dd596b78f 100644
--- a/crates/iceberg/src/scan/mod.rs
+++ b/crates/iceberg/src/scan/mod.rs
@@ -574,7 +574,7 @@ pub mod tests {
use parquet::basic::Compression;
use parquet::file::properties::WriterProperties;
use tempfile::TempDir;
- use tera::{Context, Tera};
+ use minijinja::{value::Value, AutoEscape, Environment, context};
use uuid::Uuid;
use crate::TableIdent;
@@ -589,6 +589,12 @@ pub mod tests {
};
use crate::table::Table;
+ fn render_template(template: &str, ctx: Value) -> String {
+ let mut env = Environment::new();
+ env.set_auto_escape_callback(|_| AutoEscape::None);
+ env.render_str(template, ctx).unwrap()
+ }
+
pub struct TableTestFixture {
pub table_location: String,
pub table: Table,
@@ -614,13 +620,15 @@ pub mod tests {
env!("CARGO_MANIFEST_DIR")
))
.unwrap();
- let mut context = Context::new();
- context.insert("table_location", &table_location);
- context.insert("manifest_list_1_location", &manifest_list1_location);
- context.insert("manifest_list_2_location", &manifest_list2_location);
- context.insert("table_metadata_1_location", &table_metadata1_location);
-
- let metadata_json = Tera::one_off(&template_json_str, &context, false).unwrap();
+ let metadata_json = render_template(
+ &template_json_str,
+ context! {
+ table_location => &table_location,
+ manifest_list_1_location => &manifest_list1_location,
+ manifest_list_2_location => &manifest_list2_location,
+ table_metadata_1_location => &table_metadata1_location,
+ },
+ );
serde_json::from_str::<TableMetadata>(&metadata_json).unwrap()
};
@@ -655,11 +663,13 @@ pub mod tests {
env!("CARGO_MANIFEST_DIR")
))
.unwrap();
- let mut context = Context::new();
- context.insert("table_location", &table_location);
- context.insert("table_metadata_1_location", &table_metadata1_location);
-
- let metadata_json = Tera::one_off(&template_json_str, &context, false).unwrap();
+ let metadata_json = render_template(
+ &template_json_str,
+ context! {
+ table_location => &table_location,
+ table_metadata_1_location => &table_metadata1_location,
+ },
+ );
serde_json::from_str::<TableMetadata>(&metadata_json).unwrap()
};
@@ -695,13 +705,15 @@ pub mod tests {
env!("CARGO_MANIFEST_DIR")
))
.unwrap();
- let mut context = Context::new();
- context.insert("table_location", &table_location);
- context.insert("manifest_list_1_location", &manifest_list1_location);
- context.insert("manifest_list_2_location", &manifest_list2_location);
- context.insert("table_metadata_1_location", &table_metadata1_location);
-
- let metadata_json = Tera::one_off(&template_json_str, &context, false).unwrap();
+ let metadata_json = render_template(
+ &template_json_str,
+ context! {
+ table_location => &table_location,
+ manifest_list_1_location => &manifest_list1_location,
+ manifest_list_2_location => &manifest_list2_location,
+ table_metadata_1_location => &table_metadata1_location,
+ },
+ );
serde_json::from_str::<TableMetadata>(&metadata_json).unwrap()
};