[jira] [Updated] (AMBARI-24931) Bug at MetricsCollectorHAManager class

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMBARI-24931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated AMBARI-24931:
------------------------------------
    Labels: pull-request-available  (was: )

> Bug at MetricsCollectorHAManager class
> --------------------------------------
>
>                 Key: AMBARI-24931
>                 URL: https://issues.apache.org/jira/browse/AMBARI-24931
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.8.0
>            Reporter: Myroslav Papirkovskyi
>            Assignee: Myroslav Papirkovskyi
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 2.8.0
>
>
> Here org/apache/ambari/server/controller/metrics/MetricsCollectorHAManager.java:80
> the second return statement is inside a loop without any condition. That breaks an execution flow
> {code:java}
>     if (externalMetricCollectorsState.containsKey(clusterName)) {
>       for (String externalCollectorHost : externalMetricCollectorsState.get(clusterName).keySet()) {
>         if (externalMetricCollectorsState.get(clusterName).get(externalCollectorHost)) {
>           return externalCollectorHost;
>         }
>         return refreshAndReturnRandomExternalCollectorHost(clusterName);
>       }
>     }{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)