[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #5092: Add warning when creating/updating jobs that overlap.

[GitBox <gi...@apache.org>]

shamrickus commented on a change in pull request #5092:
URL: https://github.com/apache/trafficcontrol/pull/5092#discussion_r498943915



##########
File path: traffic_portal/app/src/common/service/utils/ServerUtils.js
##########
@@ -67,6 +67,24 @@ var ServerUtils = function($window, propertiesModel, userModel) {
 		);
 	};
 
+	// Takes a response object from TO and converts all of its alerts to messages acceptable by the messageModel
+	this.convertResponseToMessages = function(response) {

Review comment:
       You are correct, when I started writing the method I assumed they were differently structured, and I never revisited. It sounds like it would be a better idea to have that method combine all the alerts with the same level instead .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org