You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Shant Hovsepian (Code Review)" <ge...@cloudera.org> on 2020/08/04 02:11:42 UTC
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16280
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
IMPALA-10034: Add remaining TPC-DS queries to workload.
Include remaining TPC-DS queries to the testdata workload definition.
Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
---
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-2.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-2.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q28.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q35.test
D testdata/workloads/tpcds/queries/tpcds-decimal_v2-q38-rewrite.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q38.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q44.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q49.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q66.test
M testdata/workloads/tpcds/queries/tpcds-decimal_v2-q8.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q87.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q90.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q93.test
M tests/query_test/test_tpcds_queries.py
M tests/util/parse_util.py
17 files changed, 1,249 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/16280/1
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6219/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Aug 2020 11:32:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Shant Hovsepian (Code Review)" <ge...@cloudera.org>.
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 5:
(2 comments)
> Patch Set 4:
>
> Agree with Aman's comments about the planner tests and the changes from the official versions...
Added comments on the official variants there are only two at this point. I have kept the unofficial variants we used in the past along with the official versions just for the sake of catching an potential regressions.
Filed IMPALA-10095 for the planner tests.
http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test
File testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test:
http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test@33
PS4, Line 33: select sum(sales)
> The TPCDS query is written as two queries in one file. We separate it out l
Done
http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test
File testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test:
http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test@45
PS4, Line 45: where i_color = 'peach'
> Same as above, the TPC-DS specification has it written as two semi colon se
Done
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 5
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Aug 2020 14:28:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6219/
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Aug 2020 16:38:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6311/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 7
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Aug 2020 17:19:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6308/
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 6
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Aug 2020 19:02:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6308/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 6
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Aug 2020 13:49:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 4
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Aug 2020 05:27:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 4:
Agree with Aman's comments about the planner tests and the changes from the official versions...
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 4
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Aug 2020 16:53:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Shant Hovsepian (Code Review)" <ge...@cloudera.org>.
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test
File testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test:
http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test@33
PS4, Line 33: select sum(sales)
> Is there any specific reason why we have two tests for query 23 that are al
The TPCDS query is written as two queries in one file. We separate it out like this to make the test diffing easier. The slight difference is just how TPC-DS designed this workload.
http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test
File testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test:
http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test@45
PS4, Line 45: where i_color = 'peach'
> Is there any specific reason why we have two tests for query 24 that are al
Same as above, the TPC-DS specification has it written as two semi colon separated queries.
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 4
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Aug 2020 22:25:00 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 7
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Aug 2020 16:02:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6244/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 4
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Aug 2020 00:15:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6304/
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 5
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Aug 2020 22:49:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6819/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 4
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Aug 2020 00:41:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6950/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 5
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Aug 2020 14:45:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6305/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 5
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Aug 2020 04:14:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 2: Code-Review+1
LGTM. I can +2 but wanted to give others a chnace to have a look.
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Aug 2020 23:00:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 4:
(2 comments)
Thanks Shant for adding the remaining TPC-DS queries! I only have two very minor questions out of curiosity and do not have any other comment.
http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test
File testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test:
http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test@33
PS4, Line 33: select sum(sales)
Is there any specific reason why we have two tests for query 23 that are almost the same? It seems the only difference is the selected column(s). In TPCDS-Q23-2, the selected columns are 1) c_last_name, 2) c_first_name, and 3) sales.
http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test
File testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test:
http://gerrit.cloudera.org:8080/#/c/16280/4/testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test@45
PS4, Line 45: where i_color = 'peach'
Is there any specific reason why we have two tests for query 24 that are almost the same? It seems the only difference is this condition. In TPCDS-Q24-2, the condition is i_color = 'saddle'.
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 4
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Aug 2020 22:04:24 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Shant Hovsepian (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Fang-Yu Rao, David Rorke, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16280
to look at the new patch set (#7).
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
IMPALA-10034: Add remaining TPC-DS queries to workload.
Include remaining TPC-DS queries to the testdata workload definition.
Q8 and Q38 were using non standard variants, those have been
replaced by the official query versions. Q35 is using an official
variant. Had to escape a table alias in Q90 as we treat 'AT' as a
reserved keyword.
Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
---
M testdata/workloads/tpcds/queries/tpcds-decimal_v2-q10a.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-2.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-2.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q28.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q35a.test
D testdata/workloads/tpcds/queries/tpcds-decimal_v2-q38-rewrite.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q38.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q44.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q49.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q66.test
M testdata/workloads/tpcds/queries/tpcds-decimal_v2-q8.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q87.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q90.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q93.test
M tests/query_test/test_tpcds_queries.py
M tests/util/parse_util.py
18 files changed, 1,252 insertions(+), 105 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/16280/7
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 7
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 2:
For the variants that are added, could you add a comment about what the change from official version is.
Also, we should add all the tpcds queries to the PlannerTest's tpcds-all.test such that we can track the Explains. Is there a separate JIRA for that ?
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Aug 2020 23:30:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Shant Hovsepian (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Fang-Yu Rao, David Rorke, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16280
to look at the new patch set (#6).
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
IMPALA-10034: Add remaining TPC-DS queries to workload.
Include remaining TPC-DS queries to the testdata workload definition.
Q8 and Q38 were using non standard variants, those have been
replaced by the official query versions. Q35 is using an official
variant. Had to escape a table alias in Q90 as we treat 'AT' as a
reserved keyword.
Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
---
M testdata/workloads/tpcds/queries/tpcds-decimal_v2-q10a.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-2.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-2.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q28.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q35a.test
D testdata/workloads/tpcds/queries/tpcds-decimal_v2-q38-rewrite.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q38.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q44.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q49.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q66.test
M testdata/workloads/tpcds/queries/tpcds-decimal_v2-q8.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q87.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q90.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q93.test
M tests/query_test/test_tpcds_queries.py
M tests/util/parse_util.py
18 files changed, 1,250 insertions(+), 106 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/16280/6
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 6
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Shant Hovsepian (Code Review)" <ge...@cloudera.org>.
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 1:
Adding the missing tpc-ds queries.
Easy spot to compare the query against https://github.com/cwida/tpcds-result-reproduction
Assuming decimalv2 will be the default soon, so only added templates for those queries. Also there are slight variances from the answer sets due to decimal rounding, I assume this is expected behavior but wouldn't mind a second set of eyes.
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Aug 2020 02:23:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 6: Code-Review+1
Doing the PlannerTest changes in separate JIRA sounds good. The q23, q24 split into two does seem confusing at first..I saw your comments about the spec having such a split. Perhaps add that as a comments. I checked on the Hive side they only keep 1 version.
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 6
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Aug 2020 19:03:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6236/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 3
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Aug 2020 12:33:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Shant Hovsepian (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Fang-Yu Rao, David Rorke, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16280
to look at the new patch set (#5).
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
IMPALA-10034: Add remaining TPC-DS queries to workload.
Include remaining TPC-DS queries to the testdata workload definition.
Q8 and Q38 were using non standard variants, those have been
replaced by the official query versions. Q35 is using an official
variant. Had to escape a table alias in Q90 as we treat 'AT' as a
reserved keyword.
Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
---
M testdata/workloads/tpcds/queries/tpcds-decimal_v2-q10a.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-2.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-2.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q28.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q35a.test
D testdata/workloads/tpcds/queries/tpcds-decimal_v2-q38-rewrite.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q38.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q44.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q49.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q66.test
M testdata/workloads/tpcds/queries/tpcds-decimal_v2-q8.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q87.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q90.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q93.test
M tests/query_test/test_tpcds_queries.py
M tests/util/parse_util.py
18 files changed, 1,250 insertions(+), 106 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/16280/5
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 5
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
IMPALA-10034: Add remaining TPC-DS queries to workload.
Include remaining TPC-DS queries to the testdata workload definition.
Q8 and Q38 were using non standard variants, those have been
replaced by the official query versions. Q35 is using an official
variant. Had to escape a table alias in Q90 as we treat 'AT' as a
reserved keyword.
Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Reviewed-on: http://gerrit.cloudera.org:8080/16280
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M testdata/workloads/tpcds/queries/tpcds-decimal_v2-q10a.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-2.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-2.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q28.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q35a.test
D testdata/workloads/tpcds/queries/tpcds-decimal_v2-q38-rewrite.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q38.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q44.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q49.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q66.test
M testdata/workloads/tpcds/queries/tpcds-decimal_v2-q8.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q87.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q90.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q93.test
M tests/query_test/test_tpcds_queries.py
M tests/util/parse_util.py
18 files changed, 1,252 insertions(+), 105 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 8
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Shant Hovsepian (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Fang-Yu Rao, David Rorke, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16280
to look at the new patch set (#4).
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
IMPALA-10034: Add remaining TPC-DS queries to workload.
Include remaining TPC-DS queries to the testdata workload definition.
Q8 and Q38 were using non standard variants, those have been
replaced by the official query versions. Q35 is using an official
variant. Had to escape a table alias in Q90 as we treat 'AT' as a
reserved keyword.
Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
---
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-2.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-2.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q28.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q35.test
D testdata/workloads/tpcds/queries/tpcds-decimal_v2-q38-rewrite.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q38.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q44.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q49.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q66.test
M testdata/workloads/tpcds/queries/tpcds-decimal_v2-q8.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q87.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q90.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q93.test
M tests/query_test/test_tpcds_queries.py
M tests/util/parse_util.py
17 files changed, 1,248 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/16280/4
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 4
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6304/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 5
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Aug 2020 17:36:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6236/
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 3
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Aug 2020 17:46:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6957/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 7
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Aug 2020 14:52:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 7
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Aug 2020 22:27:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 5:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6305/
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 5
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Aug 2020 09:22:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Shant Hovsepian (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16280
to look at the new patch set (#2).
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
IMPALA-10034: Add remaining TPC-DS queries to workload.
Include remaining TPC-DS queries to the testdata workload definition.
Q8 and Q38 were using non standard variants, those have been
replaced by the official query versions. Q35 is using an official
variant. Had to escape a table alias in Q90 as we treat 'AT' as a
reserved keyword.
Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
---
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-1.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q23-2.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-1.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q24-2.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q28.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q35.test
D testdata/workloads/tpcds/queries/tpcds-decimal_v2-q38-rewrite.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q38.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q44.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q49.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q66.test
M testdata/workloads/tpcds/queries/tpcds-decimal_v2-q8.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q87.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q90.test
A testdata/workloads/tpcds/queries/tpcds-decimal_v2-q93.test
M tests/query_test/test_tpcds_queries.py
M tests/util/parse_util.py
17 files changed, 1,249 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/16280/2
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 2
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6776/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 1
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Aug 2020 02:40:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 )
Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6951/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5436689390f149694f14e6da1df624de4f5f7ad
Gerrit-Change-Number: 16280
Gerrit-PatchSet: 6
Gerrit-Owner: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Shant Hovsepian <sh...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Aug 2020 14:09:14 +0000
Gerrit-HasComments: No