You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/12/16 10:00:46 UTC

[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #7265: [BUG] Rewrite Bigint SlotRef to compare DecimalLiteral in Binary predicate

xinyiZzz commented on a change in pull request #7265:
URL: https://github.com/apache/incubator-doris/pull/7265#discussion_r770388339



##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/DecimalLiteral.java
##########
@@ -231,6 +231,14 @@ public int getFracValue() {
         return fracPart.intValue();
     }
 
+    public void roundCeiling() {
+        value = value.setScale(0, 2);

Review comment:
       Thats right

##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/DecimalLiteral.java
##########
@@ -231,6 +231,14 @@ public int getFracValue() {
         return fracPart.intValue();
     }
 
+    public void roundCeiling() {
+        value = value.setScale(0, 2);
+    }
+
+    public void roundFloor() {
+        value = value.setScale(0, 3);

Review comment:
       Thats right




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org