You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/23 12:28:14 UTC
[GitHub] [airflow] potiuk opened a new pull request #19772: Add option to run PRs on public runners by maintainers.
potiuk opened a new pull request #19772:
URL: https://github.com/apache/airflow/pull/19772
When `use public runners` label is applied to a PR, that PR will
run on Public Runners even if it is created by the maintainer.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #19772: Add option to run PRs on public runners by maintainers.
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #19772:
URL: https://github.com/apache/airflow/pull/19772#discussion_r755178216
##########
File path: .github/workflows/ci.yml
##########
@@ -219,6 +208,24 @@ jobs:
# Run all checks
./scripts/ci/selective_ci_checks.sh
fi
+ # Avoid having to specify the runs-on logic every time. We use the custom
+ # env var AIRFLOW_SELF_HOSTED_RUNNER set only on our runners, but never
+ # on the public runners
+ - name: Set runs-on
+ id: set-runs-on
+ env:
+ PR_LABELS: "${{ steps.source-run-info.outputs.pullRequestLabels }}"
+ run: |
+ if [[ ${PR_LABELS=} == *"use public runners"* ]]; then
+ echo "Forcing running the on Public Runners via `use public runners` label"
Review comment:
```suggestion
echo "Forcing running on Public Runners via `use public runners` label"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19772: Add option to run PRs on public runners by maintainers.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19772:
URL: https://github.com/apache/airflow/pull/19772#issuecomment-976607173
Kind request to approve that one - it will help with testing the OOM issue with Public Runners. IT allows to set a label for Maintainer PR to get the tests run on "public runners" so that we can easier iterate on it in PR when trying solutions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19772: Add option to run PRs on public runners by maintainers.
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19772:
URL: https://github.com/apache/airflow/pull/19772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19772: Add option to run PRs on public runners by maintainers.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19772:
URL: https://github.com/apache/airflow/pull/19772#issuecomment-976620755
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org