You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/20 13:43:31 UTC

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5292: risc-v/mpfs: switch from riscv_lowputc() to up_putc()

pkarashchenko opened a new pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292


   ## Summary
   Switch from riscv_lowputc() to up_putc()
   
   ## Impact
   No impact
   
   ## Testing
   Pass CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] eenurkka commented on pull request #5292: risc-v/mpfs: switch to NuttX types for opensbi

Posted by GitBox <gi...@apache.org>.
eenurkka commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1017633710


   Thanks, appreciated! will test tomorrow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5292: risc-v/mpfs: switch from riscv_lowputc() to up_putc()

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1017583266


   I think it could be fixed by define OPENSBI_EXTERNAL_SBI_TYPES


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5292: risc-v/mpfs: switch to NuttX types for opensbi

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1018449881


   I fixed link process in https://github.com/apache/incubator-nuttx/pull/5303 as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5292: risc-v/mpfs: switch to NuttX types for opensbi

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1018347227


   But, why the CI doesn't have warning or error?
   https://github.com/apache/incubator-nuttx/runs/4883947690?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5292: risc-v/mpfs: switch to NuttX types for opensbi

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5292: risc-v/mpfs: switch to NuttX types for opensbi

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1018439956


   @eenurkka please try these changes https://github.com/apache/incubator-nuttx/pull/5303


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5292: risc-v/mpfs: switch to NuttX types for opensbi

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1018369363


   I just tried clean build and it also fails. I've created https://github.com/apache/incubator-nuttx/pull/5302


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5292: risc-v/mpfs: switch to NuttX types for opensbi

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1018370228


   There are much more dependencies than `OPENSBI_EXTERNAL_SBI_TYPES`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5292: risc-v/mpfs: switch from riscv_lowputc() to up_putc()

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1017531907


   > @pkarashchenko it may fail to compile due to the conflict type definition. @eenurkka, should we let open sbi use NuttX definition instead?
   
   I will check it, let me take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #5292: risc-v/mpfs: switch from riscv_lowputc() to up_putc()

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1017527481


   @pkarashchenko it may fail to compile due to the conflict type definition. @eenurkka, should we let open sbi use NuttX definition instead?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5292: risc-v/mpfs: switch from riscv_lowputc() to up_putc()

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1017527481


   @pkarashchenko it may fail to compile due to the conflict type definition.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] eenurkka commented on pull request #5292: risc-v/mpfs: switch to NuttX types for opensbi

Posted by GitBox <gi...@apache.org>.
eenurkka commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1018343319


   Actually, it compiled as I had precompiled stuff underneath; but now, if I take a clean build:
   
   tools/configure.sh icicle:opensbi
   make
   
   I get tons of redefinition warnings and errors


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5292: risc-v/mpfs: switch to NuttX types for opensbi

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1018364235


   Let's revert change for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5292: risc-v/mpfs: switch to NuttX types for opensbi

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1018442721


   BTW, by default my local build fails with
   ```
   AR (create): libboard.a   mpfs_bringup.o mpfs_appinit.o mpfs_autoleds.o mpfs_boot.o mpfs_emmcsd.o 
   make[2]: Leaving directory '/home/pkarashchenko/nuttx-upstream/nuttx/boards/risc-v/mpfs/common'
   LD: nuttx
   riscv64-unknown-elf-ld: cannot find -lm
   make[1]: *** [Makefile:168: nuttx] Error 1
   ```
   Compiler is standard `sudo apt install gcc-riscv64-unknown-elf`:
   ```
   riscv64-unknown-elf-gcc () 10.2.0
   Copyright (C) 2020 Free Software Foundation, Inc.
   This is free software; see the source for copying conditions.  There is NO
   warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
   ```
   
   Also I noticed that there is no `clean` option for opensbi case, so `distclean` should be used always in case if full rebuild is needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5292: risc-v/mpfs: switch from riscv_lowputc() to up_putc()

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1017539271


   Yes. Indeed it will not work. We need to create a separate `OPENSBI_EXTERNAL_SBI_TYPES` header file for opensbi


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] eenurkka commented on pull request #5292: risc-v/mpfs: switch to NuttX types for opensbi

Posted by GitBox <gi...@apache.org>.
eenurkka commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1018252103


   Just tested this, works just fine! Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5292: risc-v/mpfs: switch to NuttX types for opensbi

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1017591356


   > I think it could be fixed by define OPENSBI_EXTERNAL_SBI_TYPES
   
   Yes. That's what I did. please take a look
   CC: @eenurkka 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] eenurkka commented on pull request #5292: risc-v/mpfs: switch to NuttX types for opensbi

Posted by GitBox <gi...@apache.org>.
eenurkka commented on pull request #5292:
URL: https://github.com/apache/incubator-nuttx/pull/5292#issuecomment-1018356917


   Yes, I noticed that. It's strange why it goes like that. Local clean build is broken, I wonder if CI does some caching... Will look more into this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org