You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "GitToTheHub (via GitHub)" <gi...@apache.org> on 2024/10/18 05:46:54 UTC
[PR] README.md: Correct onwriteend to onwrite [cordova-plugin-file]
GitToTheHub opened a new pull request, #639:
URL: https://github.com/apache/cordova-plugin-file/pull/639
1. The `onwriteend` samples are wrong. The correct callback is `onwrite` for sucessful writes, as you can see here:
### onwrite
https://github.com/apache/cordova-plugin-file/blob/92caa81b724019b9cc63fba7a0838b69ea6312d2/www/FileWriter.js#L62-L63
### onwriteend
https://github.com/apache/cordova-plugin-file/blob/92caa81b724019b9cc63fba7a0838b69ea6312d2/www/FileWriter.js#L65-L66
2. Corrected console.log-messages in `onwrite` and `onerror`, where it mistakenly says "Successful file **read**..." instead of "**write**"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] README.md: Correct onwriteend to onwrite [cordova-plugin-file]
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek merged PR #639:
URL: https://github.com/apache/cordova-plugin-file/pull/639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org