[GitHub] [spark] gengliangwang commented on a change in pull request #33136: [SPARK-35932][SQL] Support extracting hour/minute/second from timestamp without time zone

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #33136:
URL: https://github.com/apache/spark/pull/33136#discussion_r660729422



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -968,6 +968,7 @@ object TypeCoercion extends TypeCoercionBase {
       case (StringType, target: NumericType) => target
       case (StringType, DateType) => DateType
       case (StringType, TimestampType) => TimestampType
+      case (StringType, AnyTimestampType) => TimestampType

Review comment:
       We need this for the default implicit cast from string to timestamp type. This regression is found on running extract.sql.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org