You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2016/11/30 22:33:21 UTC
Review Request 54233: ATLAS-1345: Enhance search APIs to resolve
hierarchical references
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54233/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
Bugs: ATLAS-1345
https://issues.apache.org/jira/browse/ATLAS-1345
Repository: atlas
Description
-------
ATLAS-1345: Enhance search APIs to resolve hierarchical references
Diffs
-----
intg/src/main/java/org/apache/atlas/model/SearchFilter.java b5f6c3af739ebd1383cfccc99b80abf8309803dc
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8
repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649
Diff: https://reviews.apache.org/r/54233/diff/
Testing
-------
UTs passing for AtlasTypedefStore
Thanks,
Apoorv Naik
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve
hierarchical references
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54233/#review158230
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java (line 859)
<https://reviews.apache.org/r/54233/#comment229025>
why do we need the def to type transform? Cant we have the predicates on the def instead?
- Suma Shivaprasad
On Nov. 30, 2016, 10:33 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54233/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 10:33 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1345
> https://issues.apache.org/jira/browse/ATLAS-1345
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1345: Enhance search APIs to resolve hierarchical references
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/SearchFilter.java b5f6c3af739ebd1383cfccc99b80abf8309803dc
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8
> repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649
>
> Diff: https://reviews.apache.org/r/54233/diff/
>
>
> Testing
> -------
>
> UTs passing for AtlasTypedefStore
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve
hierarchical references
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54233/
-----------------------------------------------------------
(Updated Dec. 15, 2016, 1:07 a.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
Changes
-------
Rebased with latest master
Bugs: ATLAS-1345
https://issues.apache.org/jira/browse/ATLAS-1345
Repository: atlas
Description
-------
ATLAS-1345: Enhance search APIs to resolve hierarchical references
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/SearchFilter.java 93e89c8f89d970bb8dec728e3bece7aaa24665dc
intg/src/test/java/org/apache/atlas/TestUtilsV2.java ea6d4104699b48cfafad46e6cbe9c0e83ad26102
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8
repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java cdbde1b8cf00975752df80213d06015aff3fd308
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 43414c9597b5c88c3e5fed45628abd1bbe0b9185
Diff: https://reviews.apache.org/r/54233/diff/
Testing
-------
UTs passing for AtlasTypedefStore
Thanks,
Apoorv Naik
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve
hierarchical references
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54233/#review158918
-----------------------------------------------------------
Ship it!
Ship It!
- Suma Shivaprasad
On Dec. 8, 2016, 9:08 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54233/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 9:08 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1345
> https://issues.apache.org/jira/browse/ATLAS-1345
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1345: Enhance search APIs to resolve hierarchical references
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/SearchFilter.java b5f6c3af739ebd1383cfccc99b80abf8309803dc
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java ea6d4104699b48cfafad46e6cbe9c0e83ad26102
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8
> repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java cdbde1b8cf00975752df80213d06015aff3fd308
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649
>
> Diff: https://reviews.apache.org/r/54233/diff/
>
>
> Testing
> -------
>
> UTs passing for AtlasTypedefStore
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve
hierarchical references
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54233/
-----------------------------------------------------------
(Updated Dec. 8, 2016, 9:08 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
Changes
-------
Added UTs for new search function.
Bugs: ATLAS-1345
https://issues.apache.org/jira/browse/ATLAS-1345
Repository: atlas
Description
-------
ATLAS-1345: Enhance search APIs to resolve hierarchical references
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/model/SearchFilter.java b5f6c3af739ebd1383cfccc99b80abf8309803dc
intg/src/test/java/org/apache/atlas/TestUtilsV2.java ea6d4104699b48cfafad46e6cbe9c0e83ad26102
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8
repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java cdbde1b8cf00975752df80213d06015aff3fd308
webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649
Diff: https://reviews.apache.org/r/54233/diff/
Testing
-------
UTs passing for AtlasTypedefStore
Thanks,
Apoorv Naik
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve
hierarchical references
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54233/#review158282
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java (line 843)
<https://reviews.apache.org/r/54233/#comment229055>
pls add a test for this change
- Suma Shivaprasad
On Nov. 30, 2016, 10:33 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54233/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 10:33 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1345
> https://issues.apache.org/jira/browse/ATLAS-1345
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1345: Enhance search APIs to resolve hierarchical references
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/SearchFilter.java b5f6c3af739ebd1383cfccc99b80abf8309803dc
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8
> repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649
>
> Diff: https://reviews.apache.org/r/54233/diff/
>
>
> Testing
> -------
>
> UTs passing for AtlasTypedefStore
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve
hierarchical references
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54233/#review158237
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java (line 859)
<https://reviews.apache.org/r/54233/#comment229030>
The reason for transformation is to actually resolve all hierarchical supertypes till the parent typedef. Currently the type registry deals with the TypeDef instead of *Type which means that the supertype resolution doesn't happen, so only immediate supertypes pass through the filter.
- Apoorv Naik
On Nov. 30, 2016, 10:33 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54233/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 10:33 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1345
> https://issues.apache.org/jira/browse/ATLAS-1345
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1345: Enhance search APIs to resolve hierarchical references
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/SearchFilter.java b5f6c3af739ebd1383cfccc99b80abf8309803dc
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8
> repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649
>
> Diff: https://reviews.apache.org/r/54233/diff/
>
>
> Testing
> -------
>
> UTs passing for AtlasTypedefStore
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve
hierarchical references
Posted by Apoorv Naik <na...@gmail.com>.
> On Dec. 6, 2016, 10:31 p.m., Apoorv Naik wrote:
> > repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java, line 122
> > <https://reviews.apache.org/r/54233/diff/1/?file=1573340#file1573340line122>
> >
> > The type parameter is passed in as a query param, this the toUpperCase for that and then the comparison. The other option is to try getting an enum from that value if that fails return false.
>
> Suma Shivaprasad wrote:
> yeah I think getting an enum if more efficient
Since we've moved from Class to Entity and Trait to Classification with the new APIs deriving from the Enum.valueOf will still require two if checks for these cases. So I think this is better here. Dropping the issue.
- Apoorv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54233/#review158234
-----------------------------------------------------------
On Nov. 30, 2016, 10:33 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54233/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 10:33 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1345
> https://issues.apache.org/jira/browse/ATLAS-1345
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1345: Enhance search APIs to resolve hierarchical references
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/SearchFilter.java b5f6c3af739ebd1383cfccc99b80abf8309803dc
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8
> repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649
>
> Diff: https://reviews.apache.org/r/54233/diff/
>
>
> Testing
> -------
>
> UTs passing for AtlasTypedefStore
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve
hierarchical references
Posted by Suma Shivaprasad <su...@gmail.com>.
> On Dec. 6, 2016, 10:31 p.m., Apoorv Naik wrote:
> > repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java, line 122
> > <https://reviews.apache.org/r/54233/diff/1/?file=1573340#file1573340line122>
> >
> > The type parameter is passed in as a query param, this the toUpperCase for that and then the comparison. The other option is to try getting an enum from that value if that fails return false.
yeah I think getting an enum if more efficient
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54233/#review158234
-----------------------------------------------------------
On Nov. 30, 2016, 10:33 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54233/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 10:33 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1345
> https://issues.apache.org/jira/browse/ATLAS-1345
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1345: Enhance search APIs to resolve hierarchical references
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/SearchFilter.java b5f6c3af739ebd1383cfccc99b80abf8309803dc
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8
> repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649
>
> Diff: https://reviews.apache.org/r/54233/diff/
>
>
> Testing
> -------
>
> UTs passing for AtlasTypedefStore
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve
hierarchical references
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54233/#review158234
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java (line 122)
<https://reviews.apache.org/r/54233/#comment229027>
The type parameter is passed in as a query param, this the toUpperCase for that and then the comparison. The other option is to try getting an enum from that value if that fails return false.
- Apoorv Naik
On Nov. 30, 2016, 10:33 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54233/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 10:33 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1345
> https://issues.apache.org/jira/browse/ATLAS-1345
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1345: Enhance search APIs to resolve hierarchical references
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/SearchFilter.java b5f6c3af739ebd1383cfccc99b80abf8309803dc
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8
> repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649
>
> Diff: https://reviews.apache.org/r/54233/diff/
>
>
> Testing
> -------
>
> UTs passing for AtlasTypedefStore
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 54233: ATLAS-1345: Enhance search APIs to resolve
hierarchical references
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54233/#review158229
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java (line 122)
<https://reviews.apache.org/r/54233/#comment229024>
didnt get why we need to toUppercase here..cant we directly do on typeCategory instead?
- Suma Shivaprasad
On Nov. 30, 2016, 10:33 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54233/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 10:33 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1345
> https://issues.apache.org/jira/browse/ATLAS-1345
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1345: Enhance search APIs to resolve hierarchical references
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/model/SearchFilter.java b5f6c3af739ebd1383cfccc99b80abf8309803dc
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java 816832b912130e89279cd6cd3e8c3e94c85fa6a8
> repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java d7e38b8d6423358751b3423b2695a00b126701b7
> webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 867307f04d380b7b1296c2794722b5499d6e6649
>
> Diff: https://reviews.apache.org/r/54233/diff/
>
>
> Testing
> -------
>
> UTs passing for AtlasTypedefStore
>
>
> Thanks,
>
> Apoorv Naik
>
>