[GitHub] ashb edited a comment on issue #4475: [AIRFLOW-3602] Changes ImapHook to raise an exception on no attachments

[GitBox <gi...@apache.org>]

ashb edited a comment on issue #4475: [AIRFLOW-3602] Changes ImapHook to raise an exception on no attachments
URL: https://github.com/apache/airflow/pull/4475#issuecomment-454757555
 
 
   My first though is that the Hook should probably just return `[]` (no attacments) and this sort of error handling/exception should be thrown from the Operator.
   
   The S3 case is different - getting the attachments of a message is closer to listing keys (which doesn't throw any exceptions, it returns an empty list) than getting a specific file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services