You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/21 18:12:49 UTC

[GitHub] [bookkeeper] dlg99 commented on pull request #3348: Fix the queue size in writeThreadPool exceeds the configured size

dlg99 commented on PR #3348:
URL: https://github.com/apache/bookkeeper/pull/3348#issuecomment-1162140453

   @lordcheng10 +1 to Matteo's concern about performance.
   Original implementation https://github.com/apache/bookkeeper/pull/1309 concentrated on "lightweight" over "precise size" hence it is optimistic and I think this is ok.
   checkQueue() and methods using it are not synchronized, it is possible to call it from multiple threads, pass the check and end up with more tasks in queue than the soft limit. Performance benefits eher outweigh the precision.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org