You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@harmony.apache.org by Gregory Shimansky <gs...@apache.org> on 2008/02/15 19:01:23 UTC

[drlvm] Permission to commit patch in HARMONY-5510

Hello

There is a patch that fixes HARMONY-5510. This is a regression after 
commit in HARMONY-5490. The single line change in encoder that didn't 
relate to crash handler actually caused a problem in JVMTI when decoding 
some call instructions. The decoder has to be changed to use information 
about register sizes from encoder tables, not rely on REX.W prefix which 
is not mandatory for some instructions (like calls).

I want to commit this patch to fix this regression before M5 is 
released. What do you think?

-- 
Gregory

Re: [drlvm] Permission to commit patch in HARMONY-5510

Posted by Tim Ellison <t....@gmail.com>.

Gregory Shimansky wrote:
> There is a patch that fixes HARMONY-5510. This is a regression after 
> commit in HARMONY-5490. The single line change in encoder that didn't 
> relate to crash handler actually caused a problem in JVMTI when decoding 
> some call instructions. The decoder has to be changed to use information 
> about register sizes from encoder tables, not rely on REX.W prefix which 
> is not mandatory for some instructions (like calls).
> 
> I want to commit this patch to fix this regression before M5 is 
> released. What do you think?

+1

(I don't think the testing has started in earnest yet)

Regards,
Tim