[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend
URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r323070818
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/TabbedSqlEditors.jsx
 ##########
 @@ -68,6 +69,20 @@ class TabbedSqlEditors extends React.PureComponent {
     this.removeAllOtherQueryEditors = this.removeAllOtherQueryEditors.bind(this);
   }
   componentDidMount() {
+    // migrate query editor and associated tables state to server
 
 Review comment:
   do we need to run query editor migration at every time component mounted? 
   i thought only need once after we enable the feature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org