[GitHub] rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #2562: consoleproxy: use consoleproxy.domain for non-ssl enable env
URL: https://github.com/apache/cloudstack/pull/2562#discussion_r181344148
 
 

 ##########
 File path: core/src/com/cloud/info/ConsoleProxyInfo.java
 ##########
 @@ -55,6 +57,9 @@ public ConsoleProxyInfo(boolean sslEnabled, String proxyIpAddress, int port, int
                 proxyImageUrl += ":" + this.proxyUrlPort;
         } else {
             proxyAddress = proxyIpAddress;
+            if (!Strings.isNullOrEmpty(consoleProxyUrlDomain)) {
 
 Review comment:
   @rafaelweingartner I think there is a divide in preference to use commons.lang or guava, we already have a lot of code that uses guava and things like `Strings.isNullOrEmpty`. I prefer using the guava utility/methods, also StringUtils.isNotBlank internally would do more or less the same kind of checks. I'm okay to change, but then we need a java style/doc on which methods to prefer in which case we can deprecate the use of one style over the other.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services