You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "jamesfredley (via GitHub)" <gi...@apache.org> on 2026/08/29 07:56:28 UTC

[PR] Restore RX GORM compatibility with current core APIs [grails-core]

jamesfredley opened a new pull request, #16268:
URL: https://github.com/apache/grails-core/pull/16268

   ## Summary
   
   - Remove the accidental `List`-returning `AbstractCriteriaBuilder.list(Closure)` overload that conflicts with the established reactive criteria API.
   - Restore per-`RxDatastoreClient` tenant bindings with nested-scope cleanup, client isolation, and fail-closed fallback to the core tenant holder.
   - Port `CountByFinder` to the current dynamic-finder query API and verify count projections through public finder invocation.
   
   ## Validation
   
   - Full `:grails-datamapping-core:test` and `:grails-datamapping-rx:test` suites.
   - `:grails-datamapping-rx:codeStyle` and repository-wide CodeNarc, Checkstyle, PMD, and SpotBugs aggregation with no violations.
   - Downstream MongoDB, Neo4j, and Hibernate 7 core compilation.
   - External public-surface driver confirming reactive `CriteriaBuilder.list(Closure)` emits the expected list.
   - Independent goal, code-quality, security, hands-on QA, context, Oracle, and Codex reviews.
   
   ## Root-wide test note
   
   The full repository aggregate run reached 3,570 integration tests and reported three unrelated example failures: an asynchronous SiteMesh request-recycling failure, a missing Docker environment for one Hibernate/Geb example, and a Selenium page-load timeout in the Spring Security ACL example. It also encountered the existing `grails-spring-security-ui:copyTemplates` duplicate-entry failure. All affected core and RX suites are green.
   
   @borinquenkid, please review this compatibility repair. It should be merged forward into `9.0.x` after landing on `8.1.x`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Restore RX GORM compatibility with current core APIs [grails-core]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16268:
URL: https://github.com/apache/grails-core/pull/16268#issuecomment-5461350601

   ## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16268?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `94.59459%` with `2 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 55.1600%. Comparing base ([`bb21a3a`](https://app.codecov.io/gh/apache/grails-core/commit/bb21a3aef16c97f12cf427625d464d1218248f6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bc864c6`](https://app.codecov.io/gh/apache/grails-core/commit/bc864c60ab8fae3e414bbccbb696758434e5d6b7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16268?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [.../groovy/grails/gorm/rx/multitenancy/Tenants.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16268?src=pr&el=tree&filepath=grails-datamapping-rx%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fgorm%2Frx%2Fmultitenancy%2FTenants.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLXJ4L3NyYy9tYWluL2dyb292eS9ncmFpbHMvZ29ybS9yeC9tdWx0aXRlbmFuY3kvVGVuYW50cy5ncm9vdnk=) | 93.1034% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/grails-core/pull/16268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/grails-core/pull/16268/graphs/tree.svg?width=650&height=150&src=pr&token=qJrryhpk7u&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/grails-core/pull/16268?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                 Coverage Diff                 @@
   ##                8.1.x     #16268         +/-   ##
   ===================================================
   + Coverage     29.8834%   55.1600%   +25.2766%     
   - Complexity        509      21180      +20671     
   ===================================================
     Files              79       2140       +2061     
     Lines            4715     102433      +97718     
     Branches          814      18126      +17312     
   ===================================================
   + Hits             1409      56502      +55093     
   - Misses           3063      38076      +35013     
   - Partials          243       7855       +7612     
   ```
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/grails-core/pull/16268?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...e/gorm/query/criteria/AbstractCriteriaBuilder.java](https://app.codecov.io/gh/apache/grails-core/pull/16268?src=pr&el=tree&filepath=grails-datamapping-core%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fdatastore%2Fgorm%2Fquery%2Fcriteria%2FAbstractCriteriaBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLWNvcmUvc3JjL21haW4vZ3Jvb3Z5L29yZy9ncmFpbHMvZGF0YXN0b3JlL2dvcm0vcXVlcnkvY3JpdGVyaWEvQWJzdHJhY3RDcml0ZXJpYUJ1aWxkZXIuamF2YQ==) | `64.0719% <ø> (ø)` | |
   | [...vy/org/grails/gorm/rx/finders/CountByFinder.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16268?src=pr&el=tree&filepath=grails-datamapping-rx%2Fsrc%2Fmain%2Fgroovy%2Forg%2Fgrails%2Fgorm%2Frx%2Ffinders%2FCountByFinder.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLXJ4L3NyYy9tYWluL2dyb292eS9vcmcvZ3JhaWxzL2dvcm0vcngvZmluZGVycy9Db3VudEJ5RmluZGVyLmdyb292eQ==) | `100.0000% <100.0000%> (ø)` | |
   | [.../groovy/grails/gorm/rx/multitenancy/Tenants.groovy](https://app.codecov.io/gh/apache/grails-core/pull/16268?src=pr&el=tree&filepath=grails-datamapping-rx%2Fsrc%2Fmain%2Fgroovy%2Fgrails%2Fgorm%2Frx%2Fmultitenancy%2FTenants.groovy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JhaWxzLWRhdGFtYXBwaW5nLXJ4L3NyYy9tYWluL2dyb292eS9ncmFpbHMvZ29ybS9yeC9tdWx0aXRlbmFuY3kvVGVuYW50cy5ncm9vdnk=) | `91.6667% <93.1034%> (ø)` | |
   
   ... and [2058 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16268/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Restore RX GORM compatibility with current core APIs [grails-core]

Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #16268:
URL: https://github.com/apache/grails-core/pull/16268#issuecomment-5762219206

   I'm going to close this PR since there are no changes on this PR anymore.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Restore RX GORM compatibility with current core APIs [grails-core]

Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty closed pull request #16268: Restore RX GORM compatibility with current core APIs
URL: https://github.com/apache/grails-core/pull/16268


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Restore RX GORM compatibility with current core APIs [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16268:
URL: https://github.com/apache/grails-core/pull/16268#issuecomment-5527500364

   ## 🔎 No tests executed 🔎
   
   🏷️ Commit: 73befd43c043af83f8eee146e325f9bd2daca66c
   ▶️ Tests:  0 executed
   ⚪️ Checks: 2/2 completed
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Restore RX GORM compatibility with current core APIs [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16268:
URL: https://github.com/apache/grails-core/pull/16268#issuecomment-5469803210

   ## 🚨 TestLens detected 8 failed tests 🚨
   
   Here is what you can do:
   
   1) Inspect the test failures carefully.
   2) If you are convinced that some of the tests are flaky, you can mute them below.
   3) Finally, trigger a rerun by checking the rerun checkbox.
   
   ### Test Summary
   
   #### [Groovy Snapshot Canary Build / Build Grails \(shard 0\)](https://github.com/apache/grails-core/actions/runs/33319149857/job/99278445906?pr=16268) > :grails-test-examples-app1:integrationTest
   
   | Test | Runs | Flakiness |
   |---|---|--:|
   | AsyncFunctionalSpec | ❌ | [1%&nbsp;🟡](https://github.com/apache/grails-core/issues/16030) |
   | BookFunctionalSpec | ❌ | [1%&nbsp;🟡](https://github.com/apache/grails-core/issues/16030) |
   | ConditionalOnPropertyFromPluginYmlSpec | ❌ | [1%&nbsp;🟡](https://github.com/apache/grails-core/issues/16030) |
   | ConfigTestControllerSpec | ❌ | [1%&nbsp;🟡](https://github.com/apache/grails-core/issues/16030) |
   | ControllerFromPluginSpec | ❌ | [1%&nbsp;🟡](https://github.com/apache/grails-core/issues/16030) |
   | ControllerIncludesSpec | ❌ | [1%&nbsp;🟡](https://github.com/apache/grails-core/issues/16030) |
   | DataBindingSpec | ❌ | [1%&nbsp;🟡](https://github.com/apache/grails-core/issues/16030) |
   | ErrorsFunctionalSpec | ❌ | [1%&nbsp;🟡](https://github.com/apache/grails-core/issues/16030) |
   
   🏷️ Commit: 2acb2852a29c17c910c570ce55fdd819e76ad105
   ▶️ Tests:  64320 executed
   🟡 Checks: 69/84 completed
   
   ### Test Failures
   
   <details>
   
   <summary><strong>AsyncFunctionalSpec</strong> (:grails-test-examples-app1:integrationTest in <a href="https://github.com/apache/grails-core/actions/runs/33319149857/job/99278445906?pr=16268">Groovy Snapshot Canary Build / Build Grails (shard 0)</a>)</summary>
   
   ```
   org.testcontainers.containers.ContainerLaunchException: Container startup failed for image selenium/standalone-chrome:4.43.0
   	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:346)
   	at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:317)
   	at grails.plugin.geb.WebDriverContainerHolder.startContainer(WebDriverContainerHolder.groovy:276)
   	at grails.plugin.geb.WebDriverContainerHolder.reinitialize(WebDriverContainerHolder.groovy:169)
   	at grails.plugin.geb.GrailsContainerGebExtension.visitSpec_closure2(GrailsContainerGebExtension.groovy:82)
   	at org.spockframework.runtime.extension.MethodInvocation.proceed(MethodInvocation.java:139)
   	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
   Caused by: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=selenium/standalone-chrome:4.43.0, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@51aa2a58)
   	at org.testcontainers.containers.GenericContainer.getDockerImageName(GenericContainer.java:1308)
   	at org.testcontainers.containers.GenericContainer.logger(GenericContainer.java:666)
   	at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:328)
   	... 6 more
   Caused by: org.testcontainers.shaded.org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in org.testcontainers.images.RemoteDockerImage was not fulfilled within 2 minutes.
   	at org.testcontainers.shaded.org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
   	at org.testcontainers.shaded.org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
   	at org.testcontainers.shaded.org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
   	at org.testcontainers.shaded.org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
   	at org.testcontainers.shaded.org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
   	at org.testcontainers.images.RemoteDockerImage.resolve(RemoteDockerImage.java:109)
   	at org.testcontainers.images.RemoteDockerImage.resolve(RemoteDockerImage.java:35)
   	at org.testcontainers.utility.LazyFuture.getResolvedValue(LazyFuture.java:20)
   	at org.testcontainers.utility.LazyFuture.get(LazyFuture.java:41)
   	at org.testcontainers.containers.GenericContainer.getDockerImageName(GenericContainer.java:1306)
   	... 8 more
   ```
   
   </details>
   <details>
   
   <summary><strong>BookFunctionalSpec</strong> (:grails-test-examples-app1:integrationTest in <a href="https://github.com/apache/grails-core/actions/runs/33319149857/job/99278445906?pr=16268">Groovy Snapshot Canary Build / Build Grails (shard 0)</a>)</summary>
   
   ```
   java.lang.NullPointerException: Cannot invoke "geb.test.GebTestManager.beforeTestClass(java.lang.Class)" because the return value of "grails.plugin.geb.WebDriverContainerHolder.getTestManager()" is null
   	at grails.plugin.geb.GrailsContainerGebExtension.visitSpec_closure2(GrailsContainerGebExtension.groovy:93)
   	at org.spockframework.runtime.extension.MethodInvocation.proceed(MethodInvocation.java:139)
   	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
   ```
   
   </details>
   <details>
   
   <summary><strong>ConditionalOnPropertyFromPluginYmlSpec</strong> (:grails-test-examples-app1:integrationTest in <a href="https://github.com/apache/grails-core/actions/runs/33319149857/job/99278445906?pr=16268">Groovy Snapshot Canary Build / Build Grails (shard 0)</a>)</summary>
   
   ```
   java.lang.NullPointerException: Cannot invoke "geb.test.GebTestManager.beforeTestClass(java.lang.Class)" because the return value of "grails.plugin.geb.WebDriverContainerHolder.getTestManager()" is null
   	at grails.plugin.geb.GrailsContainerGebExtension.visitSpec_closure2(GrailsContainerGebExtension.groovy:93)
   	at org.spockframework.runtime.extension.MethodInvocation.proceed(MethodInvocation.java:139)
   	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
   ```
   
   </details>
   <details>
   
   <summary><strong>ConfigTestControllerSpec</strong> (:grails-test-examples-app1:integrationTest in <a href="https://github.com/apache/grails-core/actions/runs/33319149857/job/99278445906?pr=16268">Groovy Snapshot Canary Build / Build Grails (shard 0)</a>)</summary>
   
   ```
   java.lang.NullPointerException: Cannot invoke "geb.test.GebTestManager.beforeTestClass(java.lang.Class)" because the return value of "grails.plugin.geb.WebDriverContainerHolder.getTestManager()" is null
   	at grails.plugin.geb.GrailsContainerGebExtension.visitSpec_closure2(GrailsContainerGebExtension.groovy:93)
   	at org.spockframework.runtime.extension.MethodInvocation.proceed(MethodInvocation.java:139)
   	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
   ```
   
   </details>
   <details>
   
   <summary><strong>ControllerFromPluginSpec</strong> (:grails-test-examples-app1:integrationTest in <a href="https://github.com/apache/grails-core/actions/runs/33319149857/job/99278445906?pr=16268">Groovy Snapshot Canary Build / Build Grails (shard 0)</a>)</summary>
   
   ```
   java.lang.NullPointerException: Cannot invoke "geb.test.GebTestManager.beforeTestClass(java.lang.Class)" because the return value of "grails.plugin.geb.WebDriverContainerHolder.getTestManager()" is null
   	at grails.plugin.geb.GrailsContainerGebExtension.visitSpec_closure2(GrailsContainerGebExtension.groovy:93)
   	at org.spockframework.runtime.extension.MethodInvocation.proceed(MethodInvocation.java:139)
   	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
   ```
   
   </details>
   <details>
   
   <summary><strong>ControllerIncludesSpec</strong> (:grails-test-examples-app1:integrationTest in <a href="https://github.com/apache/grails-core/actions/runs/33319149857/job/99278445906?pr=16268">Groovy Snapshot Canary Build / Build Grails (shard 0)</a>)</summary>
   
   ```
   java.lang.NullPointerException: Cannot invoke "geb.test.GebTestManager.beforeTestClass(java.lang.Class)" because the return value of "grails.plugin.geb.WebDriverContainerHolder.getTestManager()" is null
   	at grails.plugin.geb.GrailsContainerGebExtension.visitSpec_closure2(GrailsContainerGebExtension.groovy:93)
   	at org.spockframework.runtime.extension.MethodInvocation.proceed(MethodInvocation.java:139)
   	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
   ```
   
   </details>
   <details>
   
   <summary><strong>DataBindingSpec</strong> (:grails-test-examples-app1:integrationTest in <a href="https://github.com/apache/grails-core/actions/runs/33319149857/job/99278445906?pr=16268">Groovy Snapshot Canary Build / Build Grails (shard 0)</a>)</summary>
   
   ```
   java.lang.NullPointerException: Cannot invoke "geb.test.GebTestManager.beforeTestClass(java.lang.Class)" because the return value of "grails.plugin.geb.WebDriverContainerHolder.getTestManager()" is null
   	at grails.plugin.geb.GrailsContainerGebExtension.visitSpec_closure2(GrailsContainerGebExtension.groovy:93)
   	at org.spockframework.runtime.extension.MethodInvocation.proceed(MethodInvocation.java:139)
   	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
   ```
   
   </details>
   <details>
   
   <summary><strong>ErrorsFunctionalSpec</strong> (:grails-test-examples-app1:integrationTest in <a href="https://github.com/apache/grails-core/actions/runs/33319149857/job/99278445906?pr=16268">Groovy Snapshot Canary Build / Build Grails (shard 0)</a>)</summary>
   
   ```
   java.lang.NullPointerException: Cannot invoke "geb.test.GebTestManager.beforeTestClass(java.lang.Class)" because the return value of "grails.plugin.geb.WebDriverContainerHolder.getTestManager()" is null
   	at grails.plugin.geb.GrailsContainerGebExtension.visitSpec_closure2(GrailsContainerGebExtension.groovy:93)
   	at org.spockframework.runtime.extension.MethodInvocation.proceed(MethodInvocation.java:139)
   	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
   ```
   
   </details>
   
   ### Rerun Controls
   > [!NOTE]
   > Checks are currently running using the configuration below.
   
   Select tests to mute in this pull request:
   
   🔲 AsyncFunctionalSpec <!-- uniqueId=[engine:spock]/[spec:functionaltests.AsyncFunctionalSpec] -->
   🔲 BookFunctionalSpec <!-- uniqueId=[engine:spock]/[spec:functionaltests.BookFunctionalSpec] -->
   🔲 ConditionalOnPropertyFromPluginYmlSpec <!-- uniqueId=[engine:spock]/[spec:functionaltests.ConditionalOnPropertyFromPluginYmlSpec] -->
   🔲 ConfigTestControllerSpec <!-- uniqueId=[engine:spock]/[spec:functionaltests.ConfigTestControllerSpec] -->
   🔲 ControllerFromPluginSpec <!-- uniqueId=[engine:spock]/[spec:functionaltests.ControllerFromPluginSpec] -->
   🔲 ControllerIncludesSpec <!-- uniqueId=[engine:spock]/[spec:functionaltests.ControllerIncludesSpec] -->
   🔲 DataBindingSpec <!-- uniqueId=[engine:spock]/[spec:functionaltests.DataBindingSpec] -->
   🔲 ErrorsFunctionalSpec <!-- uniqueId=[engine:spock]/[spec:functionaltests.ErrorsFunctionalSpec] -->
   
   Reuse successful test results:
   
   🔲 ♻️ Only rerun the tests that failed or were muted before
   
   Click the checkbox to trigger a rerun:
   
   🔲 **Rerun jobs**
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Restore RX GORM compatibility with current core APIs [grails-core]

Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on PR #16268:
URL: https://github.com/apache/grails-core/pull/16268#issuecomment-5462020417

   @borinquenkid I will fix those forge failures separately.  We moved forge from Google Cloud to AWS yesterday.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Restore RX GORM compatibility with current core APIs [grails-core]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16268:
URL: https://github.com/apache/grails-core/pull/16268#issuecomment-5461648777

   ## ✅ All tests passed ✅
   
   🏷️ Commit: bc864c60ab8fae3e414bbccbb696758434e5d6b7
   ▶️ Tests:  72347 executed
   ⚪️ Checks: 84/84 completed
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Restore RX GORM compatibility with current core APIs [grails-core]

Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #16268:
URL: https://github.com/apache/grails-core/pull/16268#issuecomment-5589177474

   @jamesfredley there are no changes in this PR to review.  Did your merge remove them? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Restore RX GORM compatibility with current core APIs [grails-core]

Posted by "jamesfredley (via GitHub)" <gi...@apache.org>.
jamesfredley commented on PR #16268:
URL: https://github.com/apache/grails-core/pull/16268#issuecomment-5469514976

   PR #16268 was already up to date with `origin/8.1.x`. The three Forge CI jobs were failing because 8.1.x still had Shadow 8.3.6, which cannot create `startShadowScripts` on Gradle 9.6.0.
   
   Cherry-picked the already-merged 8.0.x fix from #16274 (`6703374a16`) as `2acb2852a2`: `shadowVersion=8.3.6` -> `8.3.11`. Local Forge validation on this branch passed `startShadowScripts`, `shadowDistTar`, `awsElasticBeanstalk`, and both CLI shadow jars. AWS ZIP contains `app.jar` / `Procfile` / `start.sh` / nginx proxy.conf, with `Main-Class: org.grails.forge.netty.Application`.
   
   This does not include the rest of the 8.0.x line; that remains a separate 8.0.x -> 8.1.x merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org