You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Justin Edelson <ju...@gmail.com> on 2010/04/05 15:49:45 UTC
Re: svn commit: r930612 - /sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java
Eric-
Thanks for fixing this. However, I do wonder if fixing the tests is the
right thing to do here. Or is the idea that the pre-r927338 behavior was
incorrect?
Justin
On 4/3/10 10:53 PM, enorman@apache.org wrote:
> Author: enorman
> Date: Sun Apr 4 02:53:19 2010
> New Revision: 930612
>
> URL: http://svn.apache.org/viewvc?rev=930612&view=rev
> Log:
> fixing broken launchpad.testing integration tests. The GET request from mkdir(url) that was checking if the folder already exists was failing because the node did not allow displaying an index for the folder.
>
> Modified:
> sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java
>
> Modified: sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java
> URL: http://svn.apache.org/viewvc/sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java?rev=930612&r1=930611&r2=930612&view=diff
> ==============================================================================
> --- sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java (original)
> +++ sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java Sun Apr 4 02:53:19 2010
> @@ -62,7 +62,7 @@ public class SlingIntegrationTestClient
> /** Create the given directory via WebDAV, if needed, under given URL */
> public void mkdir(String url) throws IOException {
> int status = 0;
> - status = httpClient.executeMethod(new GetMethod(url));
> + status = httpClient.executeMethod(new GetMethod(url + ".txt"));
> if(status != 200) {
> status = httpClient.executeMethod(new HttpAnyMethod("MKCOL",url));
> if(status!=201) {
>
>
Re: svn commit: r930612 - /sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java
Posted by Felix Meschberger <fm...@gmail.com>.
Hi,
On 05.04.2010 20:17, Justin Edelson wrote:
> On 4/5/10 11:39 AM, Felix Meschberger wrote:
>> Hi,
>>
>> On 05.04.2010 15:49, Justin Edelson wrote:
>>> Eric-
>>> Thanks for fixing this. However, I do wonder if fixing the tests is the
>>> right thing to do here. Or is the idea that the pre-r927338 behavior was
>>> incorrect?
>>
>> Incidentally, I also fixed this in my local checkout.
>>
>> The problem is that GETting a resource which does not adapt to an
>> InputStream may render as a child resource listing. This in turn can be
>> switched off by configuration, which is the default. [Similar to Apache
>> httpd DirectoryIndex]
>>
>> So, I consider this fix to a test case correct here.
>
> OK. Just wanted to doublecheck.
... and I thank you for doing it.
Regards
Felix
>
> Justin
>>
>> Regards
>> Felix
>>
>>>
>>> Justin
>>>
>>>
>>> On 4/3/10 10:53 PM, enorman@apache.org wrote:
>>>> Author: enorman
>>>> Date: Sun Apr 4 02:53:19 2010
>>>> New Revision: 930612
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=930612&view=rev
>>>> Log:
>>>> fixing broken launchpad.testing integration tests. The GET request from mkdir(url) that was checking if the folder already exists was failing because the node did not allow displaying an index for the folder.
>>>>
>>>> Modified:
>>>> sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java
>>>>
>>>> Modified: sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java
>>>> URL: http://svn.apache.org/viewvc/sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java?rev=930612&r1=930611&r2=930612&view=diff
>>>> ==============================================================================
>>>> --- sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java (original)
>>>> +++ sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java Sun Apr 4 02:53:19 2010
>>>> @@ -62,7 +62,7 @@ public class SlingIntegrationTestClient
>>>> /** Create the given directory via WebDAV, if needed, under given URL */
>>>> public void mkdir(String url) throws IOException {
>>>> int status = 0;
>>>> - status = httpClient.executeMethod(new GetMethod(url));
>>>> + status = httpClient.executeMethod(new GetMethod(url + ".txt"));
>>>> if(status != 200) {
>>>> status = httpClient.executeMethod(new HttpAnyMethod("MKCOL",url));
>>>> if(status!=201) {
>>>>
>>>>
>>>
>>>
>
>
Re: svn commit: r930612 - /sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java
Posted by Justin Edelson <ju...@gmail.com>.
On 4/5/10 11:39 AM, Felix Meschberger wrote:
> Hi,
>
> On 05.04.2010 15:49, Justin Edelson wrote:
>> Eric-
>> Thanks for fixing this. However, I do wonder if fixing the tests is the
>> right thing to do here. Or is the idea that the pre-r927338 behavior was
>> incorrect?
>
> Incidentally, I also fixed this in my local checkout.
>
> The problem is that GETting a resource which does not adapt to an
> InputStream may render as a child resource listing. This in turn can be
> switched off by configuration, which is the default. [Similar to Apache
> httpd DirectoryIndex]
>
> So, I consider this fix to a test case correct here.
OK. Just wanted to doublecheck.
Justin
>
> Regards
> Felix
>
>>
>> Justin
>>
>>
>> On 4/3/10 10:53 PM, enorman@apache.org wrote:
>>> Author: enorman
>>> Date: Sun Apr 4 02:53:19 2010
>>> New Revision: 930612
>>>
>>> URL: http://svn.apache.org/viewvc?rev=930612&view=rev
>>> Log:
>>> fixing broken launchpad.testing integration tests. The GET request from mkdir(url) that was checking if the folder already exists was failing because the node did not allow displaying an index for the folder.
>>>
>>> Modified:
>>> sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java
>>>
>>> Modified: sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java
>>> URL: http://svn.apache.org/viewvc/sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java?rev=930612&r1=930611&r2=930612&view=diff
>>> ==============================================================================
>>> --- sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java (original)
>>> +++ sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java Sun Apr 4 02:53:19 2010
>>> @@ -62,7 +62,7 @@ public class SlingIntegrationTestClient
>>> /** Create the given directory via WebDAV, if needed, under given URL */
>>> public void mkdir(String url) throws IOException {
>>> int status = 0;
>>> - status = httpClient.executeMethod(new GetMethod(url));
>>> + status = httpClient.executeMethod(new GetMethod(url + ".txt"));
>>> if(status != 200) {
>>> status = httpClient.executeMethod(new HttpAnyMethod("MKCOL",url));
>>> if(status!=201) {
>>>
>>>
>>
>>
Re: svn commit: r930612 - /sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java
Posted by Felix Meschberger <fm...@gmail.com>.
Hi,
On 05.04.2010 15:49, Justin Edelson wrote:
> Eric-
> Thanks for fixing this. However, I do wonder if fixing the tests is the
> right thing to do here. Or is the idea that the pre-r927338 behavior was
> incorrect?
Incidentally, I also fixed this in my local checkout.
The problem is that GETting a resource which does not adapt to an
InputStream may render as a child resource listing. This in turn can be
switched off by configuration, which is the default. [Similar to Apache
httpd DirectoryIndex]
So, I consider this fix to a test case correct here.
Regards
Felix
>
> Justin
>
>
> On 4/3/10 10:53 PM, enorman@apache.org wrote:
>> Author: enorman
>> Date: Sun Apr 4 02:53:19 2010
>> New Revision: 930612
>>
>> URL: http://svn.apache.org/viewvc?rev=930612&view=rev
>> Log:
>> fixing broken launchpad.testing integration tests. The GET request from mkdir(url) that was checking if the folder already exists was failing because the node did not allow displaying an index for the folder.
>>
>> Modified:
>> sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java
>>
>> Modified: sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java
>> URL: http://svn.apache.org/viewvc/sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java?rev=930612&r1=930611&r2=930612&view=diff
>> ==============================================================================
>> --- sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java (original)
>> +++ sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/SlingIntegrationTestClient.java Sun Apr 4 02:53:19 2010
>> @@ -62,7 +62,7 @@ public class SlingIntegrationTestClient
>> /** Create the given directory via WebDAV, if needed, under given URL */
>> public void mkdir(String url) throws IOException {
>> int status = 0;
>> - status = httpClient.executeMethod(new GetMethod(url));
>> + status = httpClient.executeMethod(new GetMethod(url + ".txt"));
>> if(status != 200) {
>> status = httpClient.executeMethod(new HttpAnyMethod("MKCOL",url));
>> if(status!=201) {
>>
>>
>
>