You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by mayunSaicmotor <gi...@git.apache.org> on 2017/09/06 15:00:01 UTC
[GitHub] carbondata pull request #1336: [CARBONDATA-1425] Inappropriate Exception dis...
GitHub user mayunSaicmotor opened a pull request:
https://github.com/apache/carbondata/pull/1336
[CARBONDATA-1425] Inappropriate Exception displays while creating a new partition with incorrect partition type
change the error content when the range info data mismatch the partition field's data type
the new showing content as below:
"Data in range info must be the same type with the partition field's type"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mayunSaicmotor/incubator-carbondata CARBONDATA-1425
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1336.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1336
----
commit c3d0debdaff3edeb67b6fb1f01f6dbfdda9a9b8a
Author: mayun <si...@163.com>
Date: 2017-09-06T14:52:39Z
fix for carbondata 1425
----
---
[GitHub] carbondata pull request #1336: [CARBONDATA-1425] Inappropriate Exception dis...
Posted by mayunSaicmotor <gi...@git.apache.org>.
Github user mayunSaicmotor commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1336#discussion_r139285031
--- Diff: integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestAlterPartitionTable.scala ---
@@ -466,6 +467,111 @@ class TestAlterPartitionTable extends QueryTest with BeforeAndAfterAll {
checkAnswer(result_after5, result_origin5)
}
+ test("test exception when alter partition and the values"
--- End diff --
actually I refer to carbondata-spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestDDLForPartitionTable.scala. All the new added test cases are belong to the same type.
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1336
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/776/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by QACarbonData <gi...@git.apache.org>.
Github user QACarbonData commented on the issue:
https://github.com/apache/carbondata/pull/1336
retest this please
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1336
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/186/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1336
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/169/
---
[GitHub] carbondata issue #1336: [WIP][CARBONDATA-1425] Inappropriate Exception displ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1336
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/584/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1336
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/176/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1336
retest this please
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1336
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/174/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1336
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/817/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1336
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/799/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1336
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/62/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by lionelcao <gi...@git.apache.org>.
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1336
LGTM
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1336
Build Failed with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/50/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1336
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/46/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1336
retest this please
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1336
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/111/
---
[GitHub] carbondata pull request #1336: [CARBONDATA-1425] Inappropriate Exception dis...
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1336#discussion_r138555709
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/partition/PartitionUtil.java ---
@@ -71,6 +72,10 @@ public static Object getDataBasedOnDataType(String data, DataType actualDataType
default:
return data;
}
+ } catch (NumberFormatException ex) {
+ return new IllegalArgumentException(ex.getMessage());
--- End diff --
can throw MalformedCarbonException instead of runtime.
Its not good coding practice to return the exception object instead of throwing it
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/1336
retest this please
---
[GitHub] carbondata pull request #1336: [CARBONDATA-1425] Inappropriate Exception dis...
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1336#discussion_r139282418
--- Diff: integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestAlterPartitionTable.scala ---
@@ -36,7 +36,8 @@ class TestAlterPartitionTable extends QueryTest with BeforeAndAfterAll {
override def beforeAll {
dropTable
-
+ CarbonProperties.getInstance()
--- End diff --
Reset this property in afterall
---
[GitHub] carbondata issue #1336: [WIP][CARBONDATA-1425] Inappropriate Exception displ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1336
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/591/
---
[GitHub] carbondata pull request #1336: [CARBONDATA-1425] Inappropriate Exception dis...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1336
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by QACarbonData <gi...@git.apache.org>.
Github user QACarbonData commented on the issue:
https://github.com/apache/carbondata/pull/1336
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/30/
---
[GitHub] carbondata issue #1336: [WIP][CARBONDATA-1425] Inappropriate Exception displ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1336
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/579/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1336
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/151/
---
[GitHub] carbondata pull request #1336: [CARBONDATA-1425] Inappropriate Exception dis...
Posted by mayunSaicmotor <gi...@git.apache.org>.
Github user mayunSaicmotor commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1336#discussion_r139284844
--- Diff: integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestAlterPartitionTable.scala ---
@@ -36,7 +36,8 @@ class TestAlterPartitionTable extends QueryTest with BeforeAndAfterAll {
override def beforeAll {
dropTable
-
+ CarbonProperties.getInstance()
--- End diff --
added
---
[GitHub] carbondata pull request #1336: [CARBONDATA-1425] Inappropriate Exception dis...
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1336#discussion_r139282463
--- Diff: integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestAlterPartitionTable.scala ---
@@ -466,6 +467,111 @@ class TestAlterPartitionTable extends QueryTest with BeforeAndAfterAll {
checkAnswer(result_after5, result_origin5)
}
+ test("test exception when alter partition and the values"
--- End diff --
Multiple tests under single test definition.split it into multiple
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1336
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/737/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1336
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1336
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/804/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1336
Build Success with Spark 1.6, Please check CI http://144.76.159.231:8080/job/ApacheCarbonPRBuilder1/11/
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by mayunSaicmotor <gi...@git.apache.org>.
Github user mayunSaicmotor commented on the issue:
https://github.com/apache/carbondata/pull/1336
retest this please
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1336
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/806/
---
[GitHub] carbondata pull request #1336: [CARBONDATA-1425] Inappropriate Exception dis...
Posted by sraghunandan <gi...@git.apache.org>.
Github user sraghunandan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1336#discussion_r139307125
--- Diff: integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestAlterPartitionTable.scala ---
@@ -466,6 +467,111 @@ class TestAlterPartitionTable extends QueryTest with BeforeAndAfterAll {
checkAnswer(result_after5, result_origin5)
}
+ test("test exception when alter partition and the values"
--- End diff --
That is also wrong.you can rework both and split into multiple test cases in another pr
---
[GitHub] carbondata issue #1336: [CARBONDATA-1425] Inappropriate Exception displays w...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1336
Build Success with Spark 1.6, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/52/
---
[GitHub] carbondata issue #1336: [WIP][CARBONDATA-1425] Inappropriate Exception displ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1336
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/583/
---