[jira] [Issue Comment Edited] (HBASE-3797) StoreFile Level Compaction Locking

["Nicolas Spiegelberg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-3797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028604#comment-13028604 ] 

Nicolas Spiegelberg edited comment on HBASE-3797 at 5/4/11 5:01 AM:
--------------------------------------------------------------------

Combined patch for HBASE-3797 & HBASE-1476.  I did not split them up because >50% of HBASE-1476 is refactoring code written for HBASE-3797.  Most of the comments I got internally about HBASE-3797 were pertaining to those deprecated code segments, so I wanted to save myself some grief on the external review :)  Note that I am having problems creating a Review Board account on review.apache.org, or I would post this up (2000+ line patch).

      was (Author: nspiegelberg):
    Combined patch for HBASE-3767 & HBASE-1476.  I did not split them up because >50% of HBASE-1476 is refactoring code written for HBASE-3767.  Most of the comments I got internally about HBASE-3767 were pertaining to those deprecated code segments, so I wanted to save myself some grief on the external review :)  Note that I am having problems creating a Review Board account on review.apache.org, or I would post this up (2000+ line patch).
  
> StoreFile Level Compaction Locking
> ----------------------------------
>
>                 Key: HBASE-3797
>                 URL: https://issues.apache.org/jira/browse/HBASE-3797
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Nicolas Spiegelberg
>            Assignee: Nicolas Spiegelberg
>            Priority: Minor
>         Attachments: HBASE-3797+1476.patch
>
>
> Multithreaded compactions (HBASE-1476) will solve the problem of major compactions clogging high-priority minor compactions.  However, there is still a problem here.  Since compactions are store-level, the store undergoing major compaction will have it's storefile count increase during the major.  We really need a way to allow multiple outstanding compactions per store.  compactSelection() should lock/reserve the files being used for compaction.  This will also allow us to know what we're going to compact when inserting into the CompactSplitThread and make more informed priority queueing decisions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira