You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "yl09099 (via GitHub)" <gi...@apache.org> on 2023/12/28 06:17:47 UTC
[PR] [#825][followup] fix(spark):Fix without returning an exception. [incubator-uniffle]
yl09099 opened a new pull request, #1402:
URL: https://github.com/apache/incubator-uniffle/pull/1402
### What changes were proposed in this pull request?
Fixes exceptions that do not need to be returned.
### Why are the changes needed?
Fix: #825
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#825][followup] fix(spark):Fix without returning an exception. [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1402:
URL: https://github.com/apache/incubator-uniffle/pull/1402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#825][followup] fix(spark):Fix without returning an exception. [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1402:
URL: https://github.com/apache/incubator-uniffle/pull/1402#issuecomment-1870865251
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1402?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`249c737`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/249c7378474e0fa642c35b8fd2dc53e98ca47a80?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.23% compared to head [(`da71c45`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1402?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.51%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1402 +/- ##
============================================
+ Coverage 53.23% 53.51% +0.28%
+ Complexity 2718 2191 -527
============================================
Files 419 342 -77
Lines 23966 15393 -8573
Branches 2042 1419 -623
============================================
- Hits 12758 8238 -4520
+ Misses 10419 6693 -3726
+ Partials 789 462 -327
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1402?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org