You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "315157973 (via GitHub)" <gi...@apache.org> on 2023/02/22 02:38:45 UTC

[GitHub] [pulsar] 315157973 commented on pull request #19559: [fix][broker] Remove useless load items

315157973 commented on PR #19559:
URL: https://github.com/apache/pulsar/pull/19559#issuecomment-1439356584

   > Please discuss this change on the mailing list. This is a fundamental change.
   
   I don't think it is a fundamental change. 
   This is an obvious bug , memory is not used in the `getMaxResourceUsage` method in the same class. 
   Two methods to get MaxResourceUsage, but the behavior is different
   
   https://github.com/apache/pulsar/blob/660525e57ed35b74cb9204521d1fba02cc08c542/pulsar-common/src/main/java/org/apache/pulsar/policies/data/loadbalancer/LocalBrokerData.java#L239-L243
   
   https://github.com/apache/pulsar/blob/660525e57ed35b74cb9204521d1fba02cc08c542/pulsar-common/src/main/java/org/apache/pulsar/policies/data/loadbalancer/LocalBrokerData.java#L253-L259


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org