You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/07/16 01:31:36 UTC
[jira] Created: (MPTEST-38) variable name typo breaks test plugin
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPTEST-38
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPTEST-38
Summary: variable name typo breaks test plugin
Type: Improvement
Status: Open
Priority: Critical
Original Estimate: 1 minute
Time Spent: Unknown
Remaining: 1 minute
Project: maven-test-plugin
Assignee: Jason van Zyl
Reporter: Jerome Lacoste
Created: Thu, 15 Jul 2004 7:30 PM
Updated: Thu, 15 Jul 2004 7:30 PM
Description:
<j:set var="maven.test.searchdir" value="${maven.test.dest}"/>
<j:if test="${context.getVariable('maven.test.search.classdir') == null}">
^^^^^
<j:set var="maven.test.searchdir" value="${pom.build.unitTestSourceDirectory}"/>
</j:if>
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPTEST-38) variable name typo breaks test plugin
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Jerome Lacoste
Created: Thu, 15 Jul 2004 7:39 PM
Body:
I may have incorrectly identified my problem badly.
My problem is that I want to only run tests which have been compiled. But the sourceModifications was not taken into account. the test plugin only compiles classes which are not excluded in the sourceModifications excludes. But after that it tries to run tests based on the test source directory.
So it tried to run classes that have not been compiled.
I thought that the reason for the problem was coming from this strange property which is not referenced anywhere else.
But I may be wrong.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPTEST-38?page=comments#action_21845
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPTEST-38
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPTEST-38
Summary: variable name typo breaks test plugin
Type: Improvement
Status: Open
Priority: Critical
Original Estimate: 1 minute
Time Spent: Unknown
Remaining: 1 minute
Project: maven-test-plugin
Assignee: Jason van Zyl
Reporter: Jerome Lacoste
Created: Thu, 15 Jul 2004 7:30 PM
Updated: Thu, 15 Jul 2004 7:39 PM
Description:
<j:set var="maven.test.searchdir" value="${maven.test.dest}"/>
<j:if test="${context.getVariable('maven.test.search.classdir') == null}">
^^^^^
<j:set var="maven.test.searchdir" value="${pom.build.unitTestSourceDirectory}"/>
</j:if>
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPTEST-38) variable name typo breaks test plugin
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Jerome Lacoste
Created: Mon, 19 Jul 2004 8:25 AM
Body:
All in all, I still don't understand why the run tests are found in the tests sources. Why don't one use the compiled classes as input?
What are the drawbacks of doing so?
Whatever the answer to that question, with the current implementation, I think that the doc should be improved to say at least in the sourceModifications doc to look at this maven.test.search.classdir property.
Or maybe this should be added as a FAQ in the wiki. The problem is that if you use sourceModifications, then you may end up with some classes not being compiled, and running the tests based on the test source directory becomes a bad idea.
And the documentation of the maven.test.search.classdir property should perhaps also mention the sourceModifications change that could result in the need for using that property. (which is to me a more frequent reason that using Groovy)
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPTEST-38?page=comments#action_21937
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPTEST-38
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPTEST-38
Summary: variable name typo breaks test plugin
Type: Improvement
Status: Open
Priority: Critical
Original Estimate: 1 minute
Time Spent: Unknown
Remaining: 1 minute
Project: maven-test-plugin
Assignee: Jason van Zyl
Reporter: Jerome Lacoste
Created: Thu, 15 Jul 2004 7:30 PM
Updated: Mon, 19 Jul 2004 8:25 AM
Description:
<j:set var="maven.test.searchdir" value="${maven.test.dest}"/>
<j:if test="${context.getVariable('maven.test.search.classdir') == null}">
^^^^^
<j:set var="maven.test.searchdir" value="${pom.build.unitTestSourceDirectory}"/>
</j:if>
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPTEST-38) variable name typo breaks test plugin
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: dion gillard
Created: Sun, 18 Jul 2004 10:38 PM
Body:
AFAIK, this isn't a typo.
>From the docs:
Use this property to specify that JUnit should search the test classes directory rather than the source directory. This allows for test cases to be written in other languages such as Groovy which generate bytecode that can then be used by this plugin. Sample :
maven.test.search.classdir=true
I agree the code doesn't make much sense though, why is the searchdir being set to ${maven.test.dest} and then in almost all cases, being overwritten to ${pom.build.unitTestSourceDirectory}
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPTEST-38?page=comments#action_21916
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPTEST-38
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPTEST-38
Summary: variable name typo breaks test plugin
Type: Improvement
Status: Open
Priority: Critical
Original Estimate: 1 minute
Time Spent: Unknown
Remaining: 1 minute
Project: maven-test-plugin
Assignee: Jason van Zyl
Reporter: Jerome Lacoste
Created: Thu, 15 Jul 2004 7:30 PM
Updated: Sun, 18 Jul 2004 10:38 PM
Description:
<j:set var="maven.test.searchdir" value="${maven.test.dest}"/>
<j:if test="${context.getVariable('maven.test.search.classdir') == null}">
^^^^^
<j:set var="maven.test.searchdir" value="${pom.build.unitTestSourceDirectory}"/>
</j:if>
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org