You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Shreepadma Venugopalan <sh...@cloudera.com> on 2014/01/23 19:54:00 UTC
Review Request 17253: SENTRY-87: Create Sentry Policy Service and Policy
Service Client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17253/
-----------------------------------------------------------
Review request for sentry and Brock Noland.
Bugs: SENTRY-87
https://issues.apache.org/jira/browse/SENTRY-87
Repository: sentry
Description
-------
Adds a new thrift based service. Also adds a new thrift based service client and a unit test.
Diffs
-----
sentry-provider/sentry-provider-db/pom.xml ce69e68
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/HiveMetaStoreSentryPolicyStoreHandler.java 76c6c90
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyService.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceHandler.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreHandler.java 779a589
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/Status.java dfbe07a
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyService.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/resources/log4j.properties PRE-CREATION
Diff: https://reviews.apache.org/r/17253/diff/
Testing
-------
Adds a new unit test that passes. Existing tests pass.
Thanks,
Shreepadma Venugopalan
Re: Review Request 17253: SENTRY-87: Create Sentry Policy Service and Policy
Service Client
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17253/#review32733
-----------------------------------------------------------
Thank you very much for doing this! I think we should:
1) Change tabs to spaces
2) Rename Sentry Policy Service to Sentry Service
and then commit it.
- Brock Noland
On Jan. 24, 2014, 2:17 a.m., Shreepadma Venugopalan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17253/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2014, 2:17 a.m.)
>
>
> Review request for sentry and Brock Noland.
>
>
> Bugs: SENTRY-87
> https://issues.apache.org/jira/browse/SENTRY-87
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Adds a new thrift based service. Also adds a new thrift based service client and a unit test.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/pom.xml ce69e68
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/HiveMetaStoreSentryPolicyStoreHandler.java 76c6c90
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyService.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceHandler.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreHandler.java 779a589
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/Status.java dfbe07a
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyService.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/test/resources/log4j.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17253/diff/
>
>
> Testing
> -------
>
> Adds a new unit test that passes. Existing tests pass.
>
>
> Thanks,
>
> Shreepadma Venugopalan
>
>
Re: Review Request 17253: SENTRY-87: Create Sentry Policy Service and Policy
Service Client
Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17253/
-----------------------------------------------------------
(Updated Jan. 25, 2014, 2:03 a.m.)
Review request for sentry and Brock Noland.
Changes
-------
Addresses the review comments.
Bugs: SENTRY-87
https://issues.apache.org/jira/browse/SENTRY-87
Repository: sentry
Description
-------
Adds a new thrift based service. Also adds a new thrift based service client and a unit test.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/pom.xml ce69e68
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/SentryThriftPolicyService.java 00862f4
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TAlterSentryRoleAddGroupsRequest.java 0960897
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TAlterSentryRoleAddGroupsResponse.java 0164c96
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TAlterSentryRoleDeleteGroupsRequest.java 02e10c3
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TAlterSentryRoleDeleteGroupsResponse.java 5720773
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TCreateSentryPrivilegeRequest.java 62f930a
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TCreateSentryPrivilegeResponse.java 76f8049
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TCreateSentryRoleRequest.java b1e3c04
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TCreateSentryRoleResponse.java f4a54b4
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TListSentryRolesRequest.java 123daef
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TListSentryRolesResponse.java 60660d6
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TSentryGroup.java b87d456
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TSentryPolicyServiceVersion.java 9c870ef
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TSentryPrivilege.java 39c7a0d
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TSentryResponseStatus.java 01b9afc
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TSentryRole.java 478f3f6
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/policystore/api/TSentryStatus.java 10b42d0
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/SentryThriftService.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TAlterSentryRoleAddGroupsRequest.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TAlterSentryRoleAddGroupsResponse.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TAlterSentryRoleDeleteGroupsRequest.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TAlterSentryRoleDeleteGroupsResponse.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TCreateSentryPrivilegeRequest.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TCreateSentryPrivilegeResponse.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TCreateSentryRoleRequest.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TCreateSentryRoleResponse.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TListSentryRolesRequest.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TListSentryRolesResponse.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TSentryGroup.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TSentryPrivilege.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TSentryResponseStatus.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TSentryRole.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TSentryServiceVersion.java PRE-CREATION
sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/service/api/TSentryStatus.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryPolicyStore.java 736e70a
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/HiveMetaStoreSentryPolicyStoreHandler.java 76c6c90
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreHandler.java 779a589
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryService.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryServiceClient.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryServiceHandler.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/Status.java dfbe07a
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/sentry_policystore.thrift 43102af
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/sentry_store.thrift PRE-CREATION
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyService.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/resources/log4j.properties PRE-CREATION
Diff: https://reviews.apache.org/r/17253/diff/
Testing
-------
Adds a new unit test that passes. Existing tests pass.
Thanks,
Shreepadma Venugopalan
Re: Review Request 17253: SENTRY-87: Create Sentry Policy Service and Policy
Service Client
Posted by Shreepadma Venugopalan <sh...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17253/
-----------------------------------------------------------
(Updated Jan. 24, 2014, 2:17 a.m.)
Review request for sentry and Brock Noland.
Changes
-------
Removed trailing WS.
Bugs: SENTRY-87
https://issues.apache.org/jira/browse/SENTRY-87
Repository: sentry
Description
-------
Adds a new thrift based service. Also adds a new thrift based service client and a unit test.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/pom.xml ce69e68
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/HiveMetaStoreSentryPolicyStoreHandler.java 76c6c90
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyService.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceHandler.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreHandler.java 779a589
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/Status.java dfbe07a
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryPolicyService.java PRE-CREATION
sentry-provider/sentry-provider-db/src/test/resources/log4j.properties PRE-CREATION
Diff: https://reviews.apache.org/r/17253/diff/
Testing
-------
Adds a new unit test that passes. Existing tests pass.
Thanks,
Shreepadma Venugopalan