You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/08/06 06:58:20 UTC

[GitHub] [incubator-echarts] easonyq opened a new pull request #13085: Fix 13009

easonyq opened a new pull request #13085:
URL: https://github.com/apache/incubator-echarts/pull/13085


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   Fix 13009
   
   **Remove unnecessary var declaration, according to #13084 **
   
   ### Fixed issues
   
   Switch 'options -> series -> showBackground' from `false` to `true` will no longer throw exceptions. (something like calling `useStyle` from undefined, more detailed described in #13009 )
   
   
   ## Details
   
   ### Before: What was the problem?
   
   Switch 'options -> series -> showBackground' from `false` to `true` will throw exceptions.
   
   
   
   ### After: How is it fixed in this PR?
   
   <!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   Switch 'options -> series -> showBackground' from `false` to `true` works well.
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   No
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [x] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] pissang merged pull request #13085: fix(bar): showBackground bug when update with no previous background elements

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #13085:
URL: https://github.com/apache/incubator-echarts/pull/13085


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #13085: fix(bar): showBackground bug when update with no previous background elements

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #13085:
URL: https://github.com/apache/incubator-echarts/pull/13085#issuecomment-669768461


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] easonyq commented on pull request #13085: fix(bar): showBackground bug when update with no previous background elements

Posted by GitBox <gi...@apache.org>.
easonyq commented on pull request #13085:
URL: https://github.com/apache/incubator-echarts/pull/13085#issuecomment-669745637


   Mainly same as #13084, but also fix a small mistakes about duplicate var declaration issue which is raised by reviewers **AFTER** PR closed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] plainheart commented on pull request #13085: fix(bar): showBackground bug when update with no previous background elements

Posted by GitBox <gi...@apache.org>.
plainheart commented on pull request #13085:
URL: https://github.com/apache/incubator-echarts/pull/13085#issuecomment-669746323


   Thank you! You're flying to solve this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [incubator-echarts] easonyq edited a comment on pull request #13085: fix(bar): showBackground bug when update with no previous background elements

Posted by GitBox <gi...@apache.org>.
easonyq edited a comment on pull request #13085:
URL: https://github.com/apache/incubator-echarts/pull/13085#issuecomment-669745637


   Mainly same as #13084, but fix a small mistake about duplicate var declaration issue (line 195) which is raised by reviewers **AFTER** PR closed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org