You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "john-jac (via GitHub)" <gi...@apache.org> on 2026/05/07 13:47:45 UTC
[PR] Add `S3VectorsPutVectorsOperator` [airflow]
john-jac opened a new pull request, #66545:
URL: https://github.com/apache/airflow/pull/66545
Adds `S3VectorsPutVectorsOperator` to insert vectors into an Amazon S3 Vectors index.
- Operator implementation
- Unit tests with mock
- Docs (RST)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `S3VectorsPutVectorsOperator` [airflow]
Posted by "john-jac (via GitHub)" <gi...@apache.org>.
john-jac commented on code in PR #66545:
URL: https://github.com/apache/airflow/pull/66545#discussion_r3204353216
##########
providers/amazon/docs/operators/s3_vectors.rst:
##########
@@ -82,3 +82,11 @@ Reference
---------
* `AWS boto3 Library Documentation for S3 Vectors <https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3vectors.html>`__
+
+.. _howto/operator:S3VectorsPutVectorsOperator:
+
+Put Vectors
+-----------
+
+To insert vectors into an Amazon S3 Vectors index, use
+:class:`~airflow.providers.amazon.aws.operators.s3_vectors.S3VectorsPutVectorsOperator`.
Review Comment:
Added the exampleinclude block referencing the [START howto_operator_s3vectors_put_vectors] marker.
##########
providers/amazon/tests/unit/amazon/aws/operators/test_s3_vectors.py:
##########
@@ -222,3 +223,31 @@ def test_execute(self):
def test_template_fields(self):
validate_template_fields(self.operator)
+
+
+VECTORS = [{"key": "vec1", "data": {"float32": [0.1, 0.2, 0.3]}}]
Review Comment:
Moved VECTORS inside the test class as a class attribute (self.VECTORS).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `S3VectorsPutVectorsOperator` [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #66545:
URL: https://github.com/apache/airflow/pull/66545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `S3VectorsPutVectorsOperator` [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #66545:
URL: https://github.com/apache/airflow/pull/66545#discussion_r3203448681
##########
providers/amazon/tests/system/amazon/aws/example_s3_vectors.py:
##########
@@ -68,6 +69,15 @@
)
# [END howto_operator_s3vectors_create_index]
+ # [START howto_operator_s3vectors_put_vectors]
+ put_vectors = S3VectorsPutVectorsOperator(
Review Comment:
Do we need to remove the vector or because we are removing the bucket we are fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `S3VectorsPutVectorsOperator` [airflow]
Posted by "SameerMesiah97 (via GitHub)" <gi...@apache.org>.
SameerMesiah97 commented on code in PR #66545:
URL: https://github.com/apache/airflow/pull/66545#discussion_r3202937567
##########
providers/amazon/docs/operators/s3_vectors.rst:
##########
@@ -82,3 +82,11 @@ Reference
---------
* `AWS boto3 Library Documentation for S3 Vectors <https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3vectors.html>`__
+
+.. _howto/operator:S3VectorsPutVectorsOperator:
+
+Put Vectors
+-----------
+
+To insert vectors into an Amazon S3 Vectors index, use
+:class:`~airflow.providers.amazon.aws.operators.s3_vectors.S3VectorsPutVectorsOperator`.
Review Comment:
Same issue as in PR #66544. exampleinclude block is missing and this new section should be above 'Reference'.
##########
providers/amazon/tests/unit/amazon/aws/operators/test_s3_vectors.py:
##########
@@ -222,3 +223,31 @@ def test_execute(self):
def test_template_fields(self):
validate_template_fields(self.operator)
+
+
+VECTORS = [{"key": "vec1", "data": {"float32": [0.1, 0.2, 0.3]}}]
Review Comment:
Since this is not being used by anything else besides `TestS3VectorsPutVectorsOperator`, perhaps it would be better to move it inside the test class you are adding?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `S3VectorsPutVectorsOperator` [airflow]
Posted by "john-jac (via GitHub)" <gi...@apache.org>.
john-jac commented on code in PR #66545:
URL: https://github.com/apache/airflow/pull/66545#discussion_r3204343362
##########
providers/amazon/tests/system/amazon/aws/example_s3_vectors.py:
##########
@@ -68,6 +69,15 @@
)
# [END howto_operator_s3vectors_create_index]
+ # [START howto_operator_s3vectors_put_vectors]
+ put_vectors = S3VectorsPutVectorsOperator(
Review Comment:
The vector bucket requires all indexes to be deleted first (per the API docs: "All vector indexes in the vector bucket must be deleted before the vector bucket can be deleted"). The system test already has delete_index before delete_vector_bucket in the chain. Individual vectors don't need explicit deletion — they're removed when the index is deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add `S3VectorsPutVectorsOperator` [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #66545:
URL: https://github.com/apache/airflow/pull/66545#issuecomment-4417449158
@john-jac — Your unresolved review thread(s) from @vincbeck appear to have been addressed (post-review commits and/or in-thread replies on every thread, with the latest commit pushed after the most recent thread). I've added the `ready for maintainer review` label so the PR re-enters the maintainer review queue.
@vincbeck — could you take another look when you have a chance? If you agree the feedback was addressed, please mark the threads as resolved so the queue signal stays accurate. If a thread still needs work, please reply in-line — @john-jac will follow up.
---
_Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this [two-stage triage process](https://github.com/apache/airflow/blob/main/contributing-docs/25_maintainer_pr_triage.md#why-the-first-pass-is-automated) so that our maintainers' limited time is spent where it matters most: the conversation with you._
---
Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org