You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/04/10 17:39:34 UTC

[GitHub] [superset] michael-s-molina commented on pull request #23637: fix: Removes Redux state mutations - iteration 3

michael-s-molina commented on PR #23637:
URL: https://github.com/apache/superset/pull/23637#issuecomment-1502100771

   @justinpark I tested all major workflows with the results of this and previous iterations and I was not able to generate immutability errors. There are many errors related to non-serializable objects being stored in Redux like BigNumbers and functions but these only generate warnings and don't block your PR. We can fix them in follow-ups.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org