You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/21 10:34:42 UTC

[GitHub] [spark] beliefer opened a new pull request #33462: [SPARK-35088][SQL][FOLLOWUP] Add test case for TimestampNTZ sequence with default step

beliefer opened a new pull request #33462:
URL: https://github.com/apache/spark/pull/33462


   ### What changes were proposed in this pull request?
   This PR follows up https://github.com/apache/spark/pull/33360 and add test case for `TimestampNTZ` sequence with default step.
   
   
   ### Why are the changes needed?
   Improve test coverage.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   Just add test cases.
   
   
   ### How was this patch tested?
   New tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33462: [SPARK-35088][SQL][FOLLOWUP] Add test case for TimestampNTZ sequence with default step

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33462:
URL: https://github.com/apache/spark/pull/33462#issuecomment-884302194


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141407/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33462: [SPARK-35088][SQL][FOLLOWUP] Add test case for TimestampNTZ sequence with default step

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33462:
URL: https://github.com/apache/spark/pull/33462#issuecomment-884097962


   **[Test build #141407 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141407/testReport)** for PR 33462 at commit [`1e16de7`](https://github.com/apache/spark/commit/1e16de7f2b354192d1719bc6176d21962558afcd).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33462: [SPARK-35088][SQL][FOLLOWUP] Add test case for TimestampNTZ sequence with default step

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33462:
URL: https://github.com/apache/spark/pull/33462#issuecomment-884302194


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141407/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33462: [SPARK-35088][SQL][FOLLOWUP] Add test case for TimestampNTZ sequence with default step

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33462:
URL: https://github.com/apache/spark/pull/33462#issuecomment-884295471


   **[Test build #141407 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141407/testReport)** for PR 33462 at commit [`1e16de7`](https://github.com/apache/spark/commit/1e16de7f2b354192d1719bc6176d21962558afcd).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang closed pull request #33462: [SPARK-35088][SQL][FOLLOWUP] Add test case for TimestampNTZ sequence with default step

Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #33462:
URL: https://github.com/apache/spark/pull/33462


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33462: [SPARK-35088][SQL][FOLLOWUP] Add test case for TimestampNTZ sequence with default step

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33462:
URL: https://github.com/apache/spark/pull/33462#issuecomment-884132571


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45924/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33462: [SPARK-35088][SQL][FOLLOWUP] Add test case for TimestampNTZ sequence with default step

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33462:
URL: https://github.com/apache/spark/pull/33462#issuecomment-884097962


   **[Test build #141407 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141407/testReport)** for PR 33462 at commit [`1e16de7`](https://github.com/apache/spark/commit/1e16de7f2b354192d1719bc6176d21962558afcd).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33462: [SPARK-35088][SQL][FOLLOWUP] Add test case for TimestampNTZ sequence with default step

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33462:
URL: https://github.com/apache/spark/pull/33462#issuecomment-884132571


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45924/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on pull request #33462: [SPARK-35088][SQL][FOLLOWUP] Add test case for TimestampNTZ sequence with default step

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #33462:
URL: https://github.com/apache/spark/pull/33462#issuecomment-884676435


   ping @gengliangwang @MaxGekk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] gengliangwang commented on pull request #33462: [SPARK-35088][SQL][FOLLOWUP] Add test case for TimestampNTZ sequence with default step

Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #33462:
URL: https://github.com/apache/spark/pull/33462#issuecomment-884788677


   Thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33462: [SPARK-35088][SQL][FOLLOWUP] Add test case for TimestampNTZ sequence with default step

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33462:
URL: https://github.com/apache/spark/pull/33462#issuecomment-884129209


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45924/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] beliefer commented on pull request #33462: [SPARK-35088][SQL][FOLLOWUP] Add test case for TimestampNTZ sequence with default step

Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #33462:
URL: https://github.com/apache/spark/pull/33462#issuecomment-885357039


   @gengliangwang Thanks a lot!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org