You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/17 15:24:29 UTC

[GitHub] [logging-log4j2] garydgregory edited a comment on pull request #706: Common unit tests for Log4j 1.x configuration factories

garydgregory edited a comment on pull request #706:
URL: https://github.com/apache/logging-log4j2/pull/706#issuecomment-1014655999


   Hi @ppkarwasz 
   Failing a build is not going to be acceptable IMO. Because different team members work at different times and availability, like me, I don't want to bring in code that breaks the build, I might have to step away and work on something else, then we would be left with a failing project build. Each PR should pass the build. If a PR fixes a bug, it should come with a test that fails without the main change.
   TY.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org