You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/25 07:41:44 UTC

[GitHub] [flink] twalthr opened a new pull request, #19565: [FLINK-27368][table-planner] Trim casts from character string to numeric

twalthr opened a new pull request, #19565:
URL: https://github.com/apache/flink/pull/19565

   ## What is the purpose of the change
   
   Restores the behavior of trimming a character string before casting it to a numeric.
   
   ## Brief change log
   
   - Trim before cast.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows: `CastRulesTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr commented on pull request #19565: [FLINK-27368][table-planner] Trim casts from character string to numeric

Posted by GitBox <gi...@apache.org>.
twalthr commented on PR #19565:
URL: https://github.com/apache/flink/pull/19565#issuecomment-1108193281

   @wuchong can you help with a review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19565: [FLINK-27368][table-planner] Trim casts from character string to numeric

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19565:
URL: https://github.com/apache/flink/pull/19565#issuecomment-1108200801

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c8dc82faaa2b5d56d50751482b04d24e94389841",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c8dc82faaa2b5d56d50751482b04d24e94389841",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c8dc82faaa2b5d56d50751482b04d24e94389841 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr closed pull request #19565: [FLINK-27368][table-planner] Trim casts from character string to numeric

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #19565: [FLINK-27368][table-planner] Trim casts from character string to numeric
URL: https://github.com/apache/flink/pull/19565


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] snuyanzin commented on pull request #19565: [FLINK-27368][table-planner] Trim casts from character string to numeric

Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #19565:
URL: https://github.com/apache/flink/pull/19565#issuecomment-1108636404

   LGTM from my side
   the only neat question I have:
   does it make sense to add a test for case with no integer part like
   ```java
   .fromCase(
                                   STRING(),
                                   fromString(" .1 "),
                                   fromBigDecimal(new BigDecimal("0.100"), 5, 3))
   ```
   postgres also supports that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr commented on pull request #19565: [FLINK-27368][table-planner] Trim casts from character string to numeric

Posted by GitBox <gi...@apache.org>.
twalthr commented on PR #19565:
URL: https://github.com/apache/flink/pull/19565#issuecomment-1117056126

   Thanks @snuyanzin. I added two additional test cases. Both work. Will merge this now...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org