You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by msokolov <gi...@git.apache.org> on 2017/08/24 18:49:21 UTC
[GitHub] lucene-solr pull request #239: Make FacetField.TYPE public
GitHub user msokolov opened a pull request:
https://github.com/apache/lucene-solr/pull/239
Make FacetField.TYPE public
Everything else in the class is public, and all the other Field.TYPE constants are public. I want to use this in a field factory class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/msokolov/lucene-solr patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/239.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #239
----
commit d7760ad675983e8b5d4edd89c983b1215b9b048b
Author: Michael Sokolov <so...@falutin.net>
Date: 2017-08-24T18:49:09Z
Make FacetField.TYPE public
Everything else in the class is public, and all the other Field.TYPE constants are public. I want to use this in a field factory class.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #239: Make FacetField.TYPE public
Posted by mikemccand <gi...@git.apache.org>.
Github user mikemccand commented on the issue:
https://github.com/apache/lucene-solr/pull/239
Thanks @msokolov, that makes sense ... I'll merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #239: Make FacetField.TYPE public
Posted by msokolov <gi...@git.apache.org>.
Github user msokolov commented on the issue:
https://github.com/apache/lucene-solr/pull/239
Thanks, Mike
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #239: Make FacetField.TYPE public
Posted by msokolov <gi...@git.apache.org>.
Github user msokolov commented on the issue:
https://github.com/apache/lucene-solr/pull/239
OK, I added the javadoc. Not sure if that commit generates e-mails on its own, so here's another message just in case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #239: Make FacetField.TYPE public
Posted by msokolov <gi...@git.apache.org>.
Github user msokolov closed the pull request at:
https://github.com/apache/lucene-solr/pull/239
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #239: Make FacetField.TYPE public
Posted by mikemccand <gi...@git.apache.org>.
Github user mikemccand commented on the issue:
https://github.com/apache/lucene-solr/pull/239
Thanks @msokolov; I'll look.
On that cryptic error you saw, that might mean your ivy version is too old: see http://lucene.472066.n3.nabble.com/BUILD-FAILED-solr-6-5-0-td4330787.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #239: Make FacetField.TYPE public
Posted by mikemccand <gi...@git.apache.org>.
Github user mikemccand commented on the issue:
https://github.com/apache/lucene-solr/pull/239
OK I pushed this for 7.1 and 8.0. Can you close this PR now? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #239: Make FacetField.TYPE public
Posted by mikemccand <gi...@git.apache.org>.
Github user mikemccand commented on the issue:
https://github.com/apache/lucene-solr/pull/239
OK `ant precommit` is angry because there are no javadocs for `TYPE` ... could you please add one? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org