You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2010/06/15 00:22:12 UTC
[jira] Created: (HBASE-2725) Shutdown hook management is gone in
trunk; restore
Shutdown hook management is gone in trunk; restore
--------------------------------------------------
Key: HBASE-2725
URL: https://issues.apache.org/jira/browse/HBASE-2725
Project: HBase
Issue Type: Bug
Reporter: stack
Assignee: stack
Priority: Blocker
Fix For: 0.21.0
Shutdown hook handling is gone from trunk. Investigate (I think I did this cleaning up tests but was over-enthusiastic pruning).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2725) Shutdown hook management is gone in
trunk; restore
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-2725:
-------------------------
Attachment: 2725.txt
First cut. Not finished yet. Adds a ShutdownHookManager that has all the ugly stuff from interrogation of context and then the running of the hooks.
> Shutdown hook management is gone in trunk; restore
> --------------------------------------------------
>
> Key: HBASE-2725
> URL: https://issues.apache.org/jira/browse/HBASE-2725
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: 2725.txt
>
>
> Shutdown hook handling is gone from trunk. Investigate (I think I did this cleaning up tests but was over-enthusiastic pruning).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2725) Shutdown hook management is gone in
trunk; restore
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879539#action_12879539 ]
HBase Review Board commented on HBASE-2725:
-------------------------------------------
Message from: stack@duboce.net
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/187/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Adds a ShutdownHook class that is package private to regionserver. Manages the running of the regionserver shutdown before running the fs shutdown hook. New class has a main so its easy to check stuff works against the different hadoops; 0.20, 0.21 and cloudera 0.20.
This addresses bug hbase-2725.
http://issues.apache.org/jira/browse/hbase-2725
Diffs
-----
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java fe9aa8a
src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/regionserver/Stoppable.java PRE-CREATION
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 479c661
Diff: http://review.hbase.org/r/187/diff
Testing
-------
Thanks,
stack
> Shutdown hook management is gone in trunk; restore
> --------------------------------------------------
>
> Key: HBASE-2725
> URL: https://issues.apache.org/jira/browse/HBASE-2725
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: 2725.txt
>
>
> Shutdown hook handling is gone from trunk. Investigate (I think I did this cleaning up tests but was over-enthusiastic pruning).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2725) Shutdown hook management is gone in
trunk; restore
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-2725:
-------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
Committed. Thanks for review J-D.
> Shutdown hook management is gone in trunk; restore
> --------------------------------------------------
>
> Key: HBASE-2725
> URL: https://issues.apache.org/jira/browse/HBASE-2725
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: 2725.txt
>
>
> Shutdown hook handling is gone from trunk. Investigate (I think I did this cleaning up tests but was over-enthusiastic pruning).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2725) Shutdown hook management is gone in
trunk; restore
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-2725:
-------------------------
Status: Patch Available (was: Open)
Looking for a reviewer
> Shutdown hook management is gone in trunk; restore
> --------------------------------------------------
>
> Key: HBASE-2725
> URL: https://issues.apache.org/jira/browse/HBASE-2725
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: 2725.txt
>
>
> Shutdown hook handling is gone from trunk. Investigate (I think I did this cleaning up tests but was over-enthusiastic pruning).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2725) Shutdown hook management is gone in
trunk; restore
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879568#action_12879568 ]
HBase Review Board commented on HBASE-2725:
-------------------------------------------
Message from: "Jean-Daniel Cryans" <jd...@apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/187/#review244
-----------------------------------------------------------
Ship it!
Looks good to me, nice cleanup compared to branch!
- Jean-Daniel
> Shutdown hook management is gone in trunk; restore
> --------------------------------------------------
>
> Key: HBASE-2725
> URL: https://issues.apache.org/jira/browse/HBASE-2725
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: 2725.txt
>
>
> Shutdown hook handling is gone from trunk. Investigate (I think I did this cleaning up tests but was over-enthusiastic pruning).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2725) Shutdown hook management is gone in
trunk; restore
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879249#action_12879249 ]
stack commented on HBASE-2725:
------------------------------
I looked into this. Here are the two relevant commits that cleaned branch of the shutdown hook.
SHA: 6feb8a5a4366c4e577d60d3626b505269e92000c
Author: Michael Stack <st...@apache.org>
Date: Tue Oct 06 2009 18:16:15 GMT-0700 (PDT)
Subject: HBASE-1887 Update hbase trunk to latests on hadoop 0.21 branch so we can all test sync/append
Refs: 20091006
Parent: c0a3fa39f6dcc7c73e1756445174bf0b681f1c34
The above got rid of all the reflection to find the hook in hdfs and instead moved us to use the fs.automatic.close that is in hadoop 0.21 (HADOOP-4829). I see that the setting of the fs.automatic.close==false is still in place in TRUNK.
SHA: 55160fed23b974cab37d618ddde5e25a719fbd21
Author: Michael Stack <st...@apache.org>
Date: Tue May 18 2010 12:24:36 GMT-0700 (PDT)
Subject: HBASE-2449 Local HBase does not stop properly
Parent: f992c3051ea70b696086bf63769f7a8f097ba3dc
This patch just removes all of the shutdown hook handling because its intefering w/ unit tests and running in local mode w/o consideration for why we had the shutdown hook in the first place -- to run orderly shutdown of the regionserver on signal.
So, need to restore the facility where on signal, we flush memstores and close out regions nicely and then go down. With durable hbase, we can now tolerate a kill -9 but subsequent startup will be slow as master has to split all regionserver logs.
I can't just look at the hadoop version and then do old school or new since as J-D discovered over in HBASE-2728, HADOOP-4829 is in place in the cloudera distribution (i.e. power-hadoop-0.20).
> Shutdown hook management is gone in trunk; restore
> --------------------------------------------------
>
> Key: HBASE-2725
> URL: https://issues.apache.org/jira/browse/HBASE-2725
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Blocker
> Fix For: 0.21.0
>
>
> Shutdown hook handling is gone from trunk. Investigate (I think I did this cleaning up tests but was over-enthusiastic pruning).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.