[jira] Commented: (OFBIZ-1227) survey screen fix

["Jonathon Wong (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527691 ] 

Jonathon Wong commented on OFBIZ-1227:
--------------------------------------

Why remove parameter "partyId" for request "ViewSurveyResponses"? Is it because it is not used at all? If so, I agree with it.

> If you search for survey from find survey screen (for example with id = 1)
> you will get all the surveys stating with id=1, but at this stage the survey
> menu will appears, thinking that we choose a survey with id 1

Your fix is correct. The "CommonSurveyDecorator" should not set field "surveyId", nor retrieve entity Survey. Screens like "FindSurvey" depend on "CommonSurveyDecorator", but is not a survey-specific screen. Survey-specific screens are like "EditSurvey", which also depends on "CommonSurveyDecorator".

> if you add a product with survey to shopping cart and try to see the survey,
> the given link is broken

I couldn't reproduce this bug. More details, please?

I searched Ecommerce module, but couldn't find any references to "ViewSurveyResponses".

I also tried using the OrderMgr module to test the surveys. There's a bug in there, surveys cannot be responded to (error msg "You have already responded to this survey; multiple responses are not allowed").

> survey screen fix
> -----------------
>
>                 Key: OFBIZ-1227
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1227
>             Project: OFBiz
>          Issue Type: Bug
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: Bilgin Ibryam
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: survey.patch
>
>
> Here i will explain the bugs fixed:
> if you add a product with survey to shopping cart and try to see the survey, the given link is broken. I add some code the get the surveyId from surveyResponseId.
> If you search for survey from find survey screen (for example with id = 1) you will get all the surveys stating with id=1, but at this stage the survey menu will appears, thinking that we choose a survey with id 1. And this survey menu is broken(surveyId=1, it is only a search criteria, not an existing survey id). Removing some unused fields from FindSurveyscreen and CommonSurveyDecorator fixed these bugs.
> I also have a question/proposal: Isn't it better to change the links ( from shopping cart and order review screens )  from  ViewSurveyResponses to EditSurveyResponse. If we change it, clicking on the survey link from an order/shoppingcart item, will show us the exact survey response and ability to edit it, instead of all the responses to the survey, as it is now ?
> Bilgin Ibryam

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.