You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/23 03:18:52 UTC
[GitHub] [apisix] Yiyiyimu opened a new pull request #2282: doc: fix typo
Yiyiyimu opened a new pull request #2282:
URL: https://github.com/apache/apisix/pull/2282
### What this PR does / why we need it:
fix #2262 and other doc typos
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2282: doc: fix typo
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2282:
URL: https://github.com/apache/apisix/pull/2282#discussion_r493251264
##########
File path: apisix/plugins/batch-requests.lua
##########
@@ -45,7 +45,7 @@ local req_schema = {
timeout = {
description = "pipeline timeout(ms)",
type = "integer",
- default = 30000,
+ default = 3000,
Review comment:
agree: update doc and keep them in one PR.
pleaes confirm you update the doc and write a right summary ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2282: doc: fix typo
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #2282:
URL: https://github.com/apache/apisix/pull/2282#discussion_r493269208
##########
File path: apisix/plugins/batch-requests.lua
##########
@@ -45,7 +45,7 @@ local req_schema = {
timeout = {
description = "pipeline timeout(ms)",
type = "integer",
- default = 30000,
+ default = 3000,
Review comment:
Write the summary in the first block of this PR. Hope I make it clear :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #2282: doc: fix typo
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2282:
URL: https://github.com/apache/apisix/pull/2282#discussion_r493212313
##########
File path: apisix/plugins/batch-requests.lua
##########
@@ -45,7 +45,7 @@ local req_schema = {
timeout = {
description = "pipeline timeout(ms)",
type = "integer",
- default = 30000,
+ default = 3000,
Review comment:
or write a summary of what this PR does?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2282: doc: fix typo
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #2282:
URL: https://github.com/apache/apisix/pull/2282#discussion_r493242304
##########
File path: apisix/plugins/batch-requests.lua
##########
@@ -45,7 +45,7 @@ local req_schema = {
timeout = {
description = "pipeline timeout(ms)",
type = "integer",
- default = 30000,
+ default = 3000,
Review comment:
> 1. Default timeout in [code](https://github.com/apache/apisix/blob/master/apisix/plugins/batch-requests.lua#L48) is set to 30000. but in [doc](https://github.com/apache/apisix/blob/master/apisix/plugins/batch-requests.lua#L48) it's 3000.
update `doc` is better.
_Originally posted by @membphis in https://github.com/apache/apisix/issues/2262#issuecomment-697154388_
---
Since I turned to update the doc but not the code, I think we could keep them in one PR.
And thank you @juzhiyuan I write a summary. It was too messy without the list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming merged pull request #2282: doc: fix typo
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #2282:
URL: https://github.com/apache/apisix/pull/2282
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #2282: doc: fix typo
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2282:
URL: https://github.com/apache/apisix/pull/2282#discussion_r493212313
##########
File path: apisix/plugins/batch-requests.lua
##########
@@ -45,7 +45,7 @@ local req_schema = {
timeout = {
description = "pipeline timeout(ms)",
type = "integer",
- default = 30000,
+ default = 3000,
Review comment:
or write a summary about what this PR does?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2282: doc: fix typo
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2282:
URL: https://github.com/apache/apisix/pull/2282#discussion_r493211825
##########
File path: apisix/plugins/batch-requests.lua
##########
@@ -45,7 +45,7 @@ local req_schema = {
timeout = {
description = "pipeline timeout(ms)",
type = "integer",
- default = 30000,
+ default = 3000,
Review comment:
one PR for one thing. I think you can revert this line and submit it in a new PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org