[GitHub] [rocketmq-externals] gripson commented on a change in pull request #557: [ISSUE 556: unused local variable]

[GitBox <gi...@apache.org>]

gripson commented on a change in pull request #557: [ISSUE 556: unused local variable]
URL: https://github.com/apache/rocketmq-externals/pull/557#discussion_r407218646
 
 

 ##########
 File path: rocketmq-connect/rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/service/ConfigManagementServiceImpl.java
 ##########
 @@ -186,12 +186,15 @@ public void removeConnectorConfig(String connectorName) {
         ConnectKeyValue config = new ConnectKeyValue();
         config.put(RuntimeConfigDefine.UPDATE_TIMESATMP, System.currentTimeMillis());
         config.put(RuntimeConfigDefine.CONFIG_DELETED, 1);
-        Map<String, ConnectKeyValue> connectorConfig = new HashMap<>();
-        connectorConfig.put(connectorName, config);
         List<ConnectKeyValue> taskConfigList = new ArrayList<>();
         taskConfigList.add(config);
 
         connectorKeyValueStore.put(connectorName, config);
+        try {
+            putConnectorConfig(connectorName, config);
 
 Review comment:
   @imaffe Could you please give more details about where and how does putConnectorConfig() function put a tombstone record? My understanding here is that `putConnectorConfig(connectorName, config); ` will probably only reload jdbc connector. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services