You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/02/07 08:53:28 UTC

[GitHub] [beam] otourzan commented on pull request #12960: [BEAM-9804] Allow user configuration of BigQuery temporary dataset

otourzan commented on pull request #12960:
URL: https://github.com/apache/beam/pull/12960#issuecomment-774637281


   I may not have understood this change correctly but I see 2 issues here.
   
   1- _BigQuerySource is the private one and users don't call it. It supposed to be called through BigQuerySource [1]. Those 2 classes don't use kwargs and temp_data set is not defined in init parameters of public one as well so it's not accessible to users, right?
   
   2- ReadFromBigQuery and _CustomBigQuerySource handle kwargs, but I think the temp_daatset needs to be documented in ReadFromBigQuery docs as the public method users use.
   
   [1]: https://github.com/apache/beam/blob/b74fcf7b30d956fb42830d652a57b265a1546973/sdks/python/apache_beam/io/gcp/bigquery.py#L492


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org