[jira] [Comment Edited] (TEZ-2662) Provide a way to check whether AM or task opts are valid and error if not

["Siddharth Seth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717594#comment-14717594 ] 

Siddharth Seth edited comment on TEZ-2662 at 8/27/15 9:48 PM:
--------------------------------------------------------------

Mostly looks good. Do we need the class to be configurable ?
Assuming the regex does not contain GC to allow for future rules to be added ?

Should gcOpts.put(opt, 1); be gcOpts.put(opt, val);

One bit this will disallow is " -XX:+UseParNewGC -XX:+UseConcMarkSweepGC " - which can be specified together.


was (Author: sseth):
Mostly looks good. Do we need the class to be configurable ?
Assuming the regex does not contain GC to allow for future rules to be added ?

One bit this will disallow is " -XX:+UseParNewGC -XX:+UseConcMarkSweepGC " - which can be specified together.

> Provide a way to check whether AM or task opts are valid and error if not 
> --------------------------------------------------------------------------
>
>                 Key: TEZ-2662
>                 URL: https://issues.apache.org/jira/browse/TEZ-2662
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Hitesh Shah
>            Assignee: Hitesh Shah
>         Attachments: TEZ-2662.1.patch, TEZ-2662.2.patch
>
>
> Current impl appends cmd-opts specified in config to programmatic opts provided. This creates potential conflicts when using UseParallelGC v/s UseG1GC 
> Tez should support a way to do checks for invalid java opts and error out as needed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)