You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by "asautins (via GitHub)" <gi...@apache.org> on 2023/05/27 05:00:30 UTC

[GitHub] [samza] asautins commented on pull request #1669: Re-factor DirDiffUtil.getDirDiff to traverse and test files once.

asautins commented on PR #1669:
URL: https://github.com/apache/samza/pull/1669#issuecomment-1565208898

   Updated PR from memoizing results of `areSameFile.test` to re-factoring population of `filesToUpload`, `filesToRetain`, and `filesToRemove`.  The resulting code is smaller and makes the logic of when each list is populated clearer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org