You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/04/18 21:27:51 UTC
[GitHub] [arrow] kou opened a new pull request, #35220: GH-35205: [C++][Gandiva] Don't find system Zstandard when we use bundled one
kou opened a new pull request, #35220:
URL: https://github.com/apache/arrow/pull/35220
### Rationale for this change
If we use bundled Zstandared, we should not find system Zstandard for Gandiva.
Because it's always failed.
### What changes are included in this PR?
Add a missing check whether we're using system Zstandard or bundled Zstandard.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35220: GH-35205: [C++][Gandiva] Don't find system Zstandard when we use bundled one
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35220:
URL: https://github.com/apache/arrow/pull/35220#issuecomment-1513815577
@github-actions crossbow submit -g verify-rc-source java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35220: GH-35205: [C++][Gandiva] Don't find system Zstandard when we use bundled one
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35220:
URL: https://github.com/apache/arrow/pull/35220#issuecomment-1513819958
Revision: 10ffcec258b3520c9e5efca6da9bec0f65427afa
Submitted crossbow builds: [ursacomputing/crossbow @ actions-cc7caa00a4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-cc7caa00a4)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/tree/actions-cc7caa00a4-github-java-jars)|
|verify-rc-source-cpp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737151757/jobs/8409602817)|
|verify-rc-source-cpp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737160517/jobs/8409621568)|
|verify-rc-source-cpp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737153757/jobs/8409607159)|
|verify-rc-source-cpp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737156486/jobs/8409612857)|
|verify-rc-source-cpp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737158127/jobs/8409616452)|
|verify-rc-source-cpp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737157795/jobs/8409615676)|
|verify-rc-source-cpp-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737158632/jobs/8409617638)|
|verify-rc-source-csharp-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737160726/jobs/8409622073)|
|verify-rc-source-csharp-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737157361/jobs/8409614758)|
|verify-rc-source-csharp-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737152172/jobs/8409604023)|
|verify-rc-source-csharp-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737156727/jobs/8409613403)|
|verify-rc-source-csharp-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737153218/jobs/8409605946)|
|verify-rc-source-csharp-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737158959/jobs/8409618606)|
|verify-rc-source-go-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737159240/jobs/8409619191)|
|verify-rc-source-go-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737155327/jobs/8409610238)|
|verify-rc-source-go-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737161893/jobs/8409624329)|
|verify-rc-source-go-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737154929/jobs/8409608796)|
|verify-rc-source-go-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737156523/jobs/8409612942)|
|verify-rc-source-go-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737154789/jobs/8409608491)|
|verify-rc-source-integration-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737159747/jobs/8409620090)|
|verify-rc-source-integration-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737161543/jobs/8409623741)|
|verify-rc-source-integration-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737152390/jobs/8409604280)|
|verify-rc-source-integration-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737158491/jobs/8409617347)|
|verify-rc-source-integration-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737162520/jobs/8409625627)|
|verify-rc-source-integration-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737158258/jobs/8409616781)|
|verify-rc-source-integration-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737152592/jobs/8409604761)|
|verify-rc-source-java-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737158774/jobs/8409618025)|
|verify-rc-source-java-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737151547/jobs/8409602331)|
|verify-rc-source-java-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737155930/jobs/8409611591)|
|verify-rc-source-java-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737152972/jobs/8409605463)|
|verify-rc-source-java-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737155468/jobs/8409610398)|
|verify-rc-source-js-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737162326/jobs/8409625186)|
|verify-rc-source-js-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737151327/jobs/8409602087)|
|verify-rc-source-js-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737155648/jobs/8409610941)|
|verify-rc-source-js-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737160117/jobs/8409620748)|
|verify-rc-source-js-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737154598/jobs/8409608342)|
|verify-rc-source-js-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737156238/jobs/8409612369)|
|verify-rc-source-python-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737154509/jobs/8409608378)|
|verify-rc-source-python-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737153476/jobs/8409606477)|
|verify-rc-source-python-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737160488/jobs/8409621464)|
|verify-rc-source-python-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737159044/jobs/8409618704)|
|verify-rc-source-python-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737157929/jobs/8409615978)|
|verify-rc-source-python-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737159468/jobs/8409619633)|
|verify-rc-source-python-macos-conda-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737161023/jobs/8409622613)|
|verify-rc-source-ruby-linux-almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737154983/jobs/8409609028)|
|verify-rc-source-ruby-linux-conda-latest-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737157617/jobs/8409615732)|
|verify-rc-source-ruby-linux-ubuntu-20.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737157217/jobs/8409614398)|
|verify-rc-source-ruby-linux-ubuntu-22.04-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737153796/jobs/8409607239)|
|verify-rc-source-ruby-macos-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737152775/jobs/8409605128)|
|verify-rc-source-ruby-macos-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/4737161285/jobs/8409623205)|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions/runs/4737162123/jobs/8409624843)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35220: GH-35205: [C++][Gandiva] Don't find system Zstandard when we use bundled one
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35220:
URL: https://github.com/apache/arrow/pull/35220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35220: GH-35205: [C++][Gandiva] Don't find system Zstandard when we use bundled one
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35220:
URL: https://github.com/apache/arrow/pull/35220#issuecomment-1517353935
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4127c559e12246cb99b010520960e290...1c6d5afb90f14098aceff780a1f506ef/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35220: GH-35205: [C++][Gandiva] Don't find system Zstandard when we use bundled one
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35220:
URL: https://github.com/apache/arrow/pull/35220#issuecomment-1513815121
* Closes: #35205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35220: GH-35205: [C++][Gandiva] Don't find system Zstandard when we use bundled one
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35220:
URL: https://github.com/apache/arrow/pull/35220#issuecomment-1517352974
Benchmark runs are scheduled for baseline = d7c5e4cfa50a4d7e46d799b78d56e39c9634332e and contender = ce60f2f26eeb085ee39e83e623e7b330aafb10ce. ce60f2f26eeb085ee39e83e623e7b330aafb10ce is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0fd53c21072a4a51bce258d1c18d9159...5f5eed200efa479b8ef9598addc27dae/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a830900b139c47a489c899487f46be2d...26b273fed0ad49d681c81472e524f40d/)
[Finished :arrow_down:10.46% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4127c559e12246cb99b010520960e290...1c6d5afb90f14098aceff780a1f506ef/)
[Finished :arrow_down:0.87% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/af59cf725d474825b744719f09c2c19f...255dc591def64c31ae283f4291dee151/)
Buildkite builds:
[Finished] [`ce60f2f2` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2751)
[Failed] [`ce60f2f2` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2785)
[Finished] [`ce60f2f2` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2749)
[Finished] [`ce60f2f2` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2776)
[Finished] [`d7c5e4cf` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2750)
[Failed] [`d7c5e4cf` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2784)
[Finished] [`d7c5e4cf` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2748)
[Finished] [`d7c5e4cf` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2775)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35220: GH-35205: [C++][Gandiva] Don't find system Zstandard when we use bundled one
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35220:
URL: https://github.com/apache/arrow/pull/35220#issuecomment-1513815166
:warning: GitHub issue #35205 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35220: GH-35205: [C++][Gandiva] Don't find system Zstandard when we use bundled one
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35220:
URL: https://github.com/apache/arrow/pull/35220#issuecomment-1513927579
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org