You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/07/03 04:23:34 UTC

[GitHub] [activemq-artemis] jsmucr opened a new pull request #3212: NO-JIRA Fix #3172 mechanism

jsmucr opened a new pull request #3212:
URL: https://github.com/apache/activemq-artemis/pull/3212


   Queue settings are reset to their default values upon broker.xml reload ONLY.
   Regular calls to PostOfficeImpl#updateQueue are no longer affected.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] jsmucr commented on a change in pull request #3212: NO-JIRA Fix #3172 mechanism

Posted by GitBox <gi...@apache.org>.
jsmucr commented on a change in pull request #3212:
URL: https://github.com/apache/activemq-artemis/pull/3212#discussion_r450604603



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -16,40 +16,6 @@
  */
 package org.apache.activemq.artemis.core.server.impl;
 
-import javax.management.MBeanServer;

Review comment:
       Will do.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3212: NO-JIRA Fix #3172 mechanism

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3212:
URL: https://github.com/apache/activemq-artemis/pull/3212#discussion_r450416288



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
##########
@@ -16,40 +16,6 @@
  */
 package org.apache.activemq.artemis.core.server.impl;
 
-import javax.management.MBeanServer;

Review comment:
       can you avoid these lines on the diff?
   
   it gets difficult to track changes over time.
   
   I don't think you really needed these.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] jsmucr edited a comment on pull request #3212: NO-JIRA Fix #3172 mechanism

Posted by GitBox <gi...@apache.org>.
jsmucr edited a comment on pull request #3212:
URL: https://github.com/apache/activemq-artemis/pull/3212#issuecomment-654571851


   That's disappointing. I spent literally hours running tests to make sure everything's fine. 
   
   I'll take a look at that. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] jsmucr commented on pull request #3212: NO-JIRA Fix #3172 mechanism

Posted by GitBox <gi...@apache.org>.
jsmucr commented on pull request #3212:
URL: https://github.com/apache/activemq-artemis/pull/3212#issuecomment-654571851


   That's disappointing. I spent literally hours running tests to make sure everything's fine. 
   
   I'll take look at that. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic closed pull request #3212: NO-JIRA Fix #3172 mechanism

Posted by GitBox <gi...@apache.org>.
clebertsuconic closed pull request #3212:
URL: https://github.com/apache/activemq-artemis/pull/3212


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3212: NO-JIRA Fix #3172 mechanism

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3212:
URL: https://github.com/apache/activemq-artemis/pull/3212#issuecomment-654408299


   @jsmucr although leave those two changes with me.. I will do some git-fu, checkout your branch.. make these changes.. and merge with you as the author.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3212: NO-JIRA Fix #3172 mechanism

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3212:
URL: https://github.com/apache/activemq-artemis/pull/3212#issuecomment-654416903


   this is superseded by #3213 
   
   please check


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3212: NO-JIRA Fix #3172 mechanism

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3212:
URL: https://github.com/apache/activemq-artemis/pull/3212#issuecomment-654479388


   there are tests failures as part of your changes:
   
   
   org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlTest.testRemoveQueueFilter[legacyCreateQueue=true]
   org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlTest.testRemoveQueueFilter[legacyCreateQueue=false]
   org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlUsingCoreTest.testRemoveQueueFilter[legacyCreateQueue=true]
   org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlUsingCoreTest.testRemoveQueueFilter[legacyCreateQueue=false]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] jsmucr commented on pull request #3212: NO-JIRA Fix #3172 mechanism

Posted by GitBox <gi...@apache.org>.
jsmucr commented on pull request #3212:
URL: https://github.com/apache/activemq-artemis/pull/3212#issuecomment-653348130


   @clebertsuconic @michaelandrepearce This covers the #3209 issue too. That bug was caused by #3172 unintentionally affecting all `updateQueue` calls while originally I was targeting `broker.xml` updates only. I am sorry about such severe mistake.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3212: NO-JIRA Fix #3172 mechanism

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3212:
URL: https://github.com/apache/activemq-artemis/pull/3212#issuecomment-654407225


   I don't think this is a NO-JIRA.
   
   Although you can just apply the previous JIRA given that we didn't release yet. Just use the previous JIRA-id on the commit here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org