You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/03/08 13:18:00 UTC
[GitHub] [incubator-doris] Sunt-ing opened a new pull request #5487: [Doc] correct format errors in English doc
Sunt-ing opened a new pull request #5487:
URL: https://github.com/apache/incubator-doris/pull/5487
## Proposed changes
Some formate errors in English doc.
They are very straightforward and should not break any existing build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Sunt-ing commented on pull request #5487: [Doc] correct format errors in English doc
Posted by GitBox <gi...@apache.org>.
Sunt-ing commented on pull request #5487:
URL: https://github.com/apache/incubator-doris/pull/5487#issuecomment-794935799
@EmmyMiao87 Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #5487: [Doc] correct format errors in English doc
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #5487:
URL: https://github.com/apache/incubator-doris/pull/5487#discussion_r590936552
##########
File path: docs/en/administrator-guide/http-actions/fe/get-log-file-action.md
##########
@@ -49,7 +49,7 @@ None
Specify the log type. The following types are supported:
- * `fe.audit.log`：FE 审计日志
+ * `fe.audit.log`: FE 审计日志
Review comment:
```suggestion
* `fe.audit.log`: Audit log of Frontend.
```
##########
File path: docs/en/administrator-guide/operation/metadata-operation.md
##########
@@ -145,7 +145,7 @@ Adding FE processes is described in detail in the [Deployment and Upgrade Docume
* The first time you start a new FE, you must make sure that the `meta_dir` of the FE is created, has correct permissions and is empty.
* Starting a new FE and executing the `ALTER SYSTEM ADD FOLLOWER/OBSERVER` statement adds FE to metadata in a sequence that is not required. If a new FE is started first and no statement is executed, the `current node is not added to the group. Please add it first.` in the new FE log. When the statement is executed, it enters the normal process.
* Make sure that after the previous FE is added successfully, the next FE is added.
- * Connect to MASTER FE and execute `ALTER SYSTEM ADD FOLLOWER/OBSERVER` claus。
+ * Connect to MASTER FE and execute `ALTER SYSTEM ADD FOLLOWER/OBSERVER` claus.
Review comment:
```suggestion
* Connect to MASTER FE and execute `ALTER SYSTEM ADD FOLLOWER/OBSERVER` stmt.
```
##########
File path: docs/en/administrator-guide/operation/metadata-operation.md
##########
@@ -239,7 +239,7 @@ FE currently has the following ports
* Ed_log_port: bdbje's communication port
* http_port: http port, also used to push image
-* rpc_port：FE 的 thrift server port
+* rpc_port: FE 的 thrift server port
Review comment:
```suggestion
* rpc_port: thrift server port of Frontend
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Sunt-ing commented on pull request #5487: [Doc] correct format errors in English doc
Posted by GitBox <gi...@apache.org>.
Sunt-ing commented on pull request #5487:
URL: https://github.com/apache/incubator-doris/pull/5487#issuecomment-793301670
I have updated the PR, please review it again :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #5487: [Doc] correct format errors in English doc
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #5487:
URL: https://github.com/apache/incubator-doris/pull/5487#discussion_r589875429
##########
File path: docs/en/administrator-guide/broker.md
##########
@@ -164,7 +164,7 @@ Authentication information is usually provided as a Key-Value in the Property Ma
Simple authentication means that Hadoop configures `hadoop.security.authentication` to` simple`.
- Use system users to access HDFS. Or add in the environment variable started by Broker: ```HADOOP_USER_NAME```。
+ Use system users to access HDFS. Or add in the environment variable started by Broker：```HADOOP_USER_NAME```.
Review comment:
should be half width `:` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #5487: [Doc] correct format errors in English doc
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #5487:
URL: https://github.com/apache/incubator-doris/pull/5487
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Sunt-ing commented on pull request #5487: [Doc] correct format errors in English doc
Posted by GitBox <gi...@apache.org>.
Sunt-ing commented on pull request #5487:
URL: https://github.com/apache/incubator-doris/pull/5487#issuecomment-793297734
@yangzhg Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org